Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1504)

Issue 3372041: os:Var support in JavaScript and PHP

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by bashofmann
Modified:
13 years, 4 months ago
Reviewers:
plindner1
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

The following patch adds support for the new os:var Tag in the Shindig PHP version as well as in the OpenSocial Template JavaScript

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added patch for PHP unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
php/test/gadgets/TemplateParserTest.php View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 3
bashofmann
13 years, 4 months ago (2010-12-01 18:53:13 UTC) #1
bashofmann
Added patch for PHP unit test
13 years, 4 months ago (2010-12-01 18:55:10 UTC) #2
plindner1
13 years, 4 months ago (2010-12-01 19:28:57 UTC) #3
seems okay, feel free to commit..

http://codereview.appspot.com/3372041/diff/1/features/src/main/javascript/fea...
File features/src/main/javascript/features/opensocial-templates/os.js (right):

http://codereview.appspot.com/3372041/diff/1/features/src/main/javascript/fea...
features/src/main/javascript/features/opensocial-templates/os.js:35: var value =
os.getValueFromNode_(node,'value');
2 space indents please.

http://codereview.appspot.com/3372041/diff/1/features/src/main/javascript/fea...
features/src/main/javascript/features/opensocial-templates/os.js:40: 
not sure how well this works cross-browser vs direct DOM manipulation..
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b