I'm not totally sold on the first two things. Trevor: I agree that [ragged-right] should ...
13 years, 4 months ago
(2010-12-02 09:12:00 UTC)
#2
I'm not totally sold on the first two things.
Trevor: I agree that [ragged-right] should be removed eventually, but let's
leave that for a later patch.
http://codereview.appspot.com/3369041/diff/1/Documentation/learning/fundament...
File Documentation/learning/fundamental.itely (right):
http://codereview.appspot.com/3369041/diff/1/Documentation/learning/fundament...
Documentation/learning/fundamental.itely:524: { g8\( a b[ c b\) a] g4 }
the {} around the entire input looks like a mistake (in the original version as
well; it's not your fault, James!), but see my next comment.
http://codereview.appspot.com/3369041/diff/1/Documentation/learning/fundament...
Documentation/learning/fundamental.itely:534:
@lilypond[quote,verbatim,ragged-right]
On 2010/12/01 16:53:06, Trevor Daniels wrote:
> Should also have relative=2
I see an inconsistency between having [relative=2] and having the actual input
surrounded with
{
...
}
Unless you're doing something fancy here (such as showing the exact text that
you're going to "copy and paste" into a larger example later on), then the {}
should be removed.
13 years, 4 months ago
(2010-12-02 18:00:11 UTC)
#3
>
http://codereview.appspot.com/3369041/diff/1/Documentation/learning/fundament...
> Documentation/learning/fundamental.itely:534:
> @lilypond[quote,verbatim,ragged-right]
> On 2010/12/01 16:53:06, Trevor Daniels wrote:
> > Should also have relative=2
>
> I see an inconsistency between having [relative=2] and having the actual input
> surrounded with
> {
> ...
> }
>
> Unless you're doing something fancy here (such as showing the exact text that
> you're going to "copy and paste" into a larger example later on), then the {}
> should be removed.
Removing the {} but adding the relative caused the note pitches to change
dramatically. so I had to make additional changes to the pitch indicators in the
example to bring it back inline with the original example.
On 2010/12/02 18:00:11, Jlowe wrote: > Removing the {} but adding the relative caused the ...
13 years, 4 months ago
(2010-12-03 00:10:31 UTC)
#4
On 2010/12/02 18:00:11, Jlowe wrote:
> Removing the {} but adding the relative caused the note
> pitches to change dramatically. so I had to make additional
> changes to the pitch indicators in the example to bring it
> back inline with the original example.
That's fine. It's more in keeping with the style of the rest
of the documentation now, which rarely uses absolute pitches.
Issue 3369041: Doc: Remove fragment option from @lilypond LM
(Closed)
Created 13 years, 4 months ago by pkx166h
Modified 13 years, 4 months ago
Reviewers: Trevor Daniels, Graham Percival (old account), Jlowe
Base URL:
Comments: 3