Issue 332990043: Issue 5220/3: Derive Repeat_tie_engraver from Laissez_vibrer_engraver

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 332990043: Issue 5220/3: Derive Repeat_tie_engraver from Laissez_vibrer_engraver (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 6 months ago by dak

Modified:
6 years, 5 months ago

Reviewers:
thomasmorley651

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 5220/3: Derive Repeat_tie_engraver from Laissez_vibrer_engraver Issue 5220/2: Virtualize some parts of Laissez_vibrer_engraver This is in preparation of using it for Repeat_Tie_engraver Issue 5220/1: Create laissez-vibrer-engraver.hh Still missing regtest/doc.

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -80 lines)			Patch
A +	lily/include/laissez-vibrer-engraver.hh	View	2 chunks	+19 lines, -15 lines	0 comments	Download
M	lily/laissez-vibrer-engraver.cc	View	4 chunks	+22 lines, -17 lines	0 comments	Download
M	lily/repeat-tie-engraver.cc	View	2 chunks	+18 lines, -48 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

thomasmorley651

6 years, 6 months ago (2017-10-24 10:29:46 UTC) #1

From testing it: LGTM

I think my own patch is obsolete now.
So I'll remove myself as owner from the tracker-issue and close 
https://codereview.appspot.com/335910043/

Expand All Messages | Collapse All Messages