Issue 3326043: Add deflate support to SkPDFStream.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3326043: Add deflate support to SkPDFStream. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by Steve VanDeBogart

Modified:
14 years, 1 month ago

Reviewers:
agl

CC:
skia-review_googlegroups.com, James Hawkins, reed

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

Add deflate support to SkPDFStream. Committed: http://code.google.com/p/skia/source/detail?r=627

Patch Set 2 : Nits #

Total comments: 4

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+209 lines, -6 lines)			Patch
M	include/config/SkUserConfig.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A	include/core/SkFlate.h	View	1	1 chunk	+48 lines, -0 lines	0 comments	Download
M	include/pdf/SkPDFStream.h	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
A	src/core/SkFlate.cpp	View	1	1 chunk	+129 lines, -0 lines	4 comments	Download
M	src/core/core_files.mk	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pdf/SkPDFStream.cpp	View		3 chunks	+20 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl

LGTM http://codereview.appspot.com/3326043/diff/2001/src/core/SkFlate.cpp File src/core/SkFlate.cpp (right): http://codereview.appspot.com/3326043/diff/2001/src/core/SkFlate.cpp#newcode75 src/core/SkFlate.cpp:75: flateData.next_out = outputBuffer; no need to set this ...

14 years, 1 month ago (2010-12-01 15:24:37 UTC) #2

Steve VanDeBogart

14 years, 1 month ago (2010-12-01 22:13:40 UTC) #3

Thanks for the review.

http://codereview.appspot.com/3326043/diff/2001/src/core/SkFlate.cpp
File src/core/SkFlate.cpp (right):

http://codereview.appspot.com/3326043/diff/2001/src/core/SkFlate.cpp#newcode75
src/core/SkFlate.cpp:75: flateData.next_out = outputBuffer;
On 2010/12/01 15:24:37, agl wrote:
> no need to set this again, it never changes.

zlib modifies this value as it consumes/produces data.

Expand All Messages | Collapse All Messages