Issue 3324042: Add values for all fields_names when singleton doesn't exist

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3324042: Add values for all fields_names when singleton doesn't exist (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by ced

Modified:
14 years, 4 months ago

Reviewers:
nicoe_old

Visibility:
Public.

Patch Set 2 : Remove list call on set #

Patch Set 3 : Add test #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	trytond/model/modelsingleton.py	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	trytond/tests/test_modelsingleton.py	View		2 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

nicoe_old

http://codereview.appspot.com/3324042/diff/1/trytond/model/modelsingleton.py File trytond/model/modelsingleton.py (right): http://codereview.appspot.com/3324042/diff/1/trytond/model/modelsingleton.py#newcode33 trytond/model/modelsingleton.py:33: fields_names = (list(set(self._columns.keys() why do you use list on ...

14 years, 5 months ago (2010-12-01 06:26:31 UTC) #2

ced

14 years, 5 months ago (2010-12-01 07:21:13 UTC) #3

Expand All Messages | Collapse All Messages