Issue 3323041: Fix unexpected client capabilities in ibus-daemon.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3323041: Fix unexpected client capabilities in ibus-daemon. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Yusuke Sato

Modified:
13 years, 7 months ago

Reviewers:
shawn.p.huang, Peng Huang, Peng

CC:
satorux

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Fix unexpected client capabilities in ibus-daemon. BUG=none TEST=manually

Patch Set 2 : review fixes #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	bus/inputcontext.c	View	1	3 chunks	+10 lines, -2 lines	0 comments	Download
	M	src/ibusinputcontext.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

http://codereview.appspot.com/3323041/diff/2001/bus/inputcontext.c File bus/inputcontext.c (right): http://codereview.appspot.com/3323041/diff/2001/bus/inputcontext.c#newcode2294 bus/inputcontext.c:2294: How about move check code to here? http://codereview.appspot.com/3323041/diff/2001/src/ibusinputcontext.h File ...

13 years, 7 months ago (2010-11-25 08:46:16 UTC) #2

Yusuke Sato

http://codereview.appspot.com/3323041/diff/2001/bus/inputcontext.c File bus/inputcontext.c (right): http://codereview.appspot.com/3323041/diff/2001/bus/inputcontext.c#newcode2294 bus/inputcontext.c:2294: On 2010/11/25 08:46:17, Shawn.P.Huang wrote: > How about move ...

13 years, 7 months ago (2010-11-25 08:51:43 UTC) #3

Peng

13 years, 7 months ago (2010-11-25 08:52:40 UTC) #4

LGTM.THX
On 2010/11/25 08:51:43, Yusuke Sato wrote:
> http://codereview.appspot.com/3323041/diff/2001/bus/inputcontext.c
> File bus/inputcontext.c (right):
> 
> http://codereview.appspot.com/3323041/diff/2001/bus/inputcontext.c#newcode2294
> bus/inputcontext.c:2294: 
> On 2010/11/25 08:46:17, Shawn.P.Huang wrote:
> > How about move check code to here?
> 
> Done. The original code is obviously bad, sorry.
> 
> http://codereview.appspot.com/3323041/diff/2001/src/ibusinputcontext.h
> File src/ibusinputcontext.h (right):
> 
>
http://codereview.appspot.com/3323041/diff/2001/src/ibusinputcontext.h#newcod...
> src/ibusinputcontext.h:178: * The panel component does nothing for an
> applications that doesn't support focus.
> On 2010/11/25 08:46:17, Shawn.P.Huang wrote:
> > applications => application
> 
> Done.

Expand All Messages | Collapse All Messages