Multiple properties for \override \override-lines markup

Multiple properties for \override \override-lines markup

This allows giving a list of pairs rather than a single one to the
\override and \override-lines markup commands.

[dak, 2017-10-08 14:38:32]

Manually improve \override situation (convert-ly rule depressingly ineffective)

[thomasmorley651, 2017-10-08 15:19:44]

LGTM

Some nits:

https://codereview.appspot.com/331860043/diff/20001/Documentation/snippets/ke...
File Documentation/snippets/keyboard-headword.ly (right):

https://codereview.appspot.com/331860043/diff/20001/Documentation/snippets/ke...
Documentation/snippets/keyboard-headword.ly:31: \override #'((direction . 1)
(baseline-skip . 2)) {
One {}-bracket-pair could be deleted as well.

https://codereview.appspot.com/331860043/diff/20001/scm/define-markup-command...
File scm/define-markup-commands.scm (right):

https://codereview.appspot.com/331860043/diff/20001/scm/define-markup-command...
scm/define-markup-commands.scm:2530: @lilypond[verbatim,quote]
How about demonstrating in the example. Suggestion:
\markup {
  \undertie "undertied"
  \override #'(offset . 15)
  \undertie "offset undertied"
  \override #'((offset . 15)(thickness . 3))
  \undertie "offset thick undertied"
}

https://codereview.appspot.com/331860043/diff/20001/scm/define-markup-command...
scm/define-markup-commands.scm:4026: \\override-lines #'(multi-measure-rest .
#t)
Why override_-lines_ here. Don't understand.

[dak, 2017-10-11 10:19:25]

https://codereview.appspot.com/331860043/diff/20001/Documentation/snippets/ke...
File Documentation/snippets/keyboard-headword.ly (right):

https://codereview.appspot.com/331860043/diff/20001/Documentation/snippets/ke...
Documentation/snippets/keyboard-headword.ly:31: \override #'((direction . 1)
(baseline-skip . 2)) {
On 2017/10/08 15:19:44, thomasmorley651 wrote:
> One {}-bracket-pair could be deleted as well.

Two, actually (all except the innermost one).  I'll take a look.

The {} reduction was manually, so it may have been incomplete/inconsistent.

https://codereview.appspot.com/331860043/diff/20001/scm/define-markup-command...
File scm/define-markup-commands.scm (right):

https://codereview.appspot.com/331860043/diff/20001/scm/define-markup-command...
scm/define-markup-commands.scm:2530: @lilypond[verbatim,quote]
On 2017/10/08 15:19:44, thomasmorley651 wrote:
> How about demonstrating in the example. Suggestion:
> \markup {
>   \undertie "undertied"
>   \override #'(offset . 15)
>   \undertie "offset undertied"
>   \override #'((offset . 15)(thickness . 3))
>   \undertie "offset thick undertied"
> }

Maybe. \markup { \line { ... } } is an abomination anyway.  Should be just
\markup { ... }.  I'll take a look.

https://codereview.appspot.com/331860043/diff/20001/scm/define-markup-command...
scm/define-markup-commands.scm:4026: \\override-lines #'(multi-measure-rest .
#t)
On 2017/10/08 15:19:44, thomasmorley651 wrote:
> Why override_-lines_ here. Don't understand.

Because \override ... { x y z } is translated into
{ \override ... x \override ... y \override ... z }
which is wasteful.

Remember that everything that is called "-lines" in markup really is talking
about a markup _list_.  Whether it ends up in lines depends on the usage.

[dak, 2017-10-11 10:26:34]

https://codereview.appspot.com/331860043/diff/20001/Documentation/snippets/ke...
File Documentation/snippets/keyboard-headword.ly (right):

https://codereview.appspot.com/331860043/diff/20001/Documentation/snippets/ke...
Documentation/snippets/keyboard-headword.ly:31: \override #'((direction . 1)
(baseline-skip . 2)) {
On 2017/10/11 10:19:25, dak wrote:
> On 2017/10/08 15:19:44, thomasmorley651 wrote:
> > One {}-bracket-pair could be deleted as well.
> 
> Two, actually (all except the innermost one).  I'll take a look.
> 
> The {} reduction was manually, so it may have been incomplete/inconsistent.

Oh, this is rubbish.  It will get overwritten by the next LSR import anyway and
is not important enough to put in snippets/new.  I'll revert.

[dak, 2017-10-11 10:35:05]

Revert changes in Documentation/snippets, incorporate Thomas Morley's suggestion

[thomasmorley651, 2017-10-11 21:08:49]

On 2017/10/11 10:19:25, dak wrote:

>
https://codereview.appspot.com/331860043/diff/20001/scm/define-markup-command...
> scm/define-markup-commands.scm:4026: \\override-lines #'(multi-measure-rest .
> #t)
> On 2017/10/08 15:19:44, thomasmorley651 wrote:
> > Why override_-lines_ here. Don't understand.
> 
> Because \override ... { x y z } is translated into
> { \override ... x \override ... y \override ... z }
> which is wasteful.
> 
> Remember that everything that is called "-lines" in markup really is talking
> about a markup _list_.  Whether it ends up in lines depends on the usage.

Ah, ofcourse. Thanks.

LGTM

[dak, 2017-10-11 21:14:14]

On 2017/10/11 21:08:49, thomasmorley651 wrote:
> On 2017/10/11 10:19:25, dak wrote:
> 
> >
>
https://codereview.appspot.com/331860043/diff/20001/scm/define-markup-command...
> > scm/define-markup-commands.scm:4026: \\override-lines #'(multi-measure-rest
.
> > #t)
> > On 2017/10/08 15:19:44, thomasmorley651 wrote:
> > > Why override_-lines_ here. Don't understand.
> > 
> > Because \override ... { x y z } is translated into
> > { \override ... x \override ... y \override ... z }
> > which is wasteful.
> > 
> > Remember that everything that is called "-lines" in markup really is talking
> > about a markup _list_.  Whether it ends up in lines depends on the usage.
> 
> Ah, ofcourse.

Also known as "this sucks".  At some point of time we might replace -lines with
-list like \markuplines was renamed to \markuplist .

But that's likely to be a large piece of work.