Issue 3310042: Ties: Print out a warning if a tie cannot be created

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3310042: Ties: Print out a warning if a tie cannot be created (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by Reinhold

Modified:
13 years, 5 months ago

Reviewers:
carl.d.sorensen, Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Ties: Print out a warning if a tie cannot be created Do not silently clear a tie attempt, but notify the user that a tie could not be created (typically either due to a typo or due to a missing tieWaitForNote)

Patch Set 1 #

Patch Set 2 : Also handle ties starting at chord (not all notes need to produce a tie) #

Total comments: 10

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -3 lines)			Patch
	A	input/regression/tie-unfinished.ly	View	1	1 chunk	+14 lines, -0 lines	3 comments	Download
	M	lily/tie-engraver.cc	View	1	9 chunks	+41 lines, -3 lines	7 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Neil Puttock

http://codereview.appspot.com/3310042/diff/2001/input/regression/tie-unfinished.ly File input/regression/tie-unfinished.ly (right): http://codereview.appspot.com/3310042/diff/2001/input/regression/tie-unfinished.ly#newcode6 input/regression/tie-unfinished.ly:6: be created, lilypond prints out a warning." but only ...

13 years, 5 months ago (2010-11-25 17:54:02 UTC) #2

All comments included/fixed and pushed to master.

Expand All Messages | Collapse All Messages