Issue 33061: Convert makeRequest code paths to use JsonSerializer instead of direct JSONObject calls

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 33061: Convert makeRequest code paths to use JsonSerializer instead of direct JSONObject calls

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 5 months ago by etnu00

Modified:
16 years, 5 months ago

Reviewers:
beaton, shindig.remailer

Base URL:
https://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 16 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -105 lines)			Patch
M	java/common/src/test/java/org/apache/shindig/common/JsonAssert.java	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/FetchResponseUtils.java	View	2 chunks	+20 lines, -17 lines	1 comment	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/HttpPreloader.java	View	2 chunks	+4 lines, -11 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java	View	3 chunks	+18 lines, -21 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/FetchResponseUtilsTest.java	View	4 chunks	+21 lines, -35 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/preload/HttpPreloaderTest.java	View	9 chunks	+24 lines, -21 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

etnu00

Attempting to clean up remaining JSONObject usage for performance and security.

16 years, 5 months ago (2009-04-03 19:23:15 UTC) #1

beaton

16 years, 5 months ago (2009-04-03 20:14:09 UTC) #2

LGTM.

http://codereview.appspot.com/33061/diff/1/7
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/FetchResponseUtils.java
(right):

http://codereview.appspot.com/33061/diff/1/7#newcode72
Line 72: Collection<String> values = response.getHeaders(name);
Looks like response.getHeaders is guaranteed immutable by the HttpResponse
contract.  Might be nice to add a comment to that effect.

Expand All Messages | Collapse All Messages