Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(368)

Issue 33055: Fix #743: reinstate warning for unterminated span dynamics. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 12 months ago by Neil Puttock
Modified:
14 years, 6 months ago
Reviewers:
Reinhold
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix #743: reinstate warning for unterminated span dynamics.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -16 lines) Patch
M lily/new-dynamic-engraver.cc View 5 chunks +35 lines, -16 lines 0 comments Download

Messages

Total messages: 2
Reinhold
I can't really judge the internals of the patch. But at least I don't see ...
14 years, 7 months ago (2009-09-01 12:04:52 UTC) #1
Neil Puttock
14 years, 6 months ago (2009-09-06 21:14:52 UTC) #2
On 2009/09/01 12:04:52, Reinhold wrote:
> I can't really judge the internals of the patch. But at least I don't see any
> obvious problem.

It should be harmless, since it's basically the same code lifted from
dynamic-engraver.cc with a slight refinement for the warning message.

> On the other hand, I would really like this to be included, as that issue has
> bitten me quite a few times while preparing ~50 small excerpts of Dvorak's
Cello
> concerto for a thesis...

OK, I'll add a regression test and rebase the code.

Regards,
Neil
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b