Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3057)

Issue 3303041: Use in memory user database to improve performance. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by Peng Huang
Modified:
13 years, 10 months ago
Reviewers:
shawn.p.huang, Yusuke Sato
CC:
satorux
Base URL:
git@github.com:/ibus/ibus-pinyin.git@master
Visibility:
Public.

Description

Use in memory user database to improve performance. I found pinyin's performance is very low when system IO load is big. So I let pinyin use im memory user database to improve the performance, and write the database to the harddisk in 60 seconds or when engine exits. BUG=none TEST=manual

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -95 lines) Patch
M src/PYDatabase.h View 1 chunk +7 lines, -2 lines 0 comments Download
M src/PYDatabase.cc View 10 chunks +192 lines, -93 lines 0 comments Download
M src/PYMain.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M src/PYString.h View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 3
Peng
13 years, 10 months ago (2010-11-24 07:18:53 UTC) #1
Yusuke Sato
lgtm http://codereview.appspot.com/3303041/diff/1/src/PYString.h File src/PYString.h (right): http://codereview.appspot.com/3303041/diff/1/src/PYString.h#newcode34 src/PYString.h:34: String (const std::string str) : std::string (str) { ...
13 years, 10 months ago (2010-11-24 07:49:22 UTC) #2
Peng
13 years, 10 months ago (2010-11-24 07:53:20 UTC) #3
http://codereview.appspot.com/3303041/diff/1/src/PYString.h
File src/PYString.h (right):

http://codereview.appspot.com/3303041/diff/1/src/PYString.h#newcode34
src/PYString.h:34: String (const std::string str) : std::string (str) { }
On 2010/11/24 07:49:22, Yusuke Sato wrote:
> do you mean 'const std::string &str'?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b