Issue 3293042: Add function comments to bus/panelproxy.[ch].

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3293042: Add function comments to bus/panelproxy.[ch]. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Yusuke Sato

Modified:
13 years, 7 months ago

Reviewers:
shawn.p.huang, Peng Huang

CC:
satorux

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Add function comments to bus/panelproxy.[ch]. BUG=none TEST=none

Patch Set 1 #

Total comments: 2

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -14 lines)			Patch
	M	bus/panelproxy.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	bus/panelproxy.c	View		11 chunks	+37 lines, -14 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Yusuke Sato

http://codereview.appspot.com/3293042/diff/1/bus/panelproxy.c File bus/panelproxy.c (right): http://codereview.appspot.com/3293042/diff/1/bus/panelproxy.c#newcode631 bus/panelproxy.c:631: /* FIXME re-enable this if needed. could you let ...

13 years, 7 months ago (2010-11-25 09:27:55 UTC) #1

Peng

LGTM http://codereview.appspot.com/3293042/diff/1/bus/panelproxy.c File bus/panelproxy.c (right): http://codereview.appspot.com/3293042/diff/1/bus/panelproxy.c#newcode631 bus/panelproxy.c:631: /* FIXME re-enable this if needed. On 2010/11/25 ...

13 years, 7 months ago (2010-11-25 09:55:19 UTC) #2

Yusuke Sato

13 years, 7 months ago (2010-11-26 01:15:30 UTC) #3

Sure, will do it in a next change.

On 2010/11/25 09:55:19, Shawn.P.Huang wrote:
> LGTM
> 
> http://codereview.appspot.com/3293042/diff/1/bus/panelproxy.c
> File bus/panelproxy.c (right):
> 
> http://codereview.appspot.com/3293042/diff/1/bus/panelproxy.c#newcode631
> bus/panelproxy.c:631: /* FIXME re-enable this if needed.
> On 2010/11/25 09:27:56, Yusuke Sato wrote:
> > could you let me know why the callback is disabled now?
> 
> Maybe it is by mistake. Please add it back.

Expand All Messages | Collapse All Messages