Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1737)

Issue 328630043: Improve warning for unattached post-event(s) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by dak
Modified:
6 years, 4 months ago
Reviewers:
thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Improve warning for unattached post-event(s) Insertion of <> was considered too confusing in the given warning: this isn't mentioned any more. Additionally, for multiple post events in a row, a warning is given for every one. Also, the _type_ of the post event is printed.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M lily/parser.yy View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 1
thomasmorley651
6 years, 6 months ago (2017-09-16 16:48:30 UTC) #1
I'm not capable to review parser-code.
But from description:
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b