Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4186)

Issue 328440043: Limit use of `make-concat-markup` in tempo tag (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 7 months ago by Ebe123
Modified:
6 years, 7 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Limit use of `make-concat-markup` in tempo tag Calling `make-concat-markup` when the list of components of the tempo tag is incomplete causes the printing command to be unnecessarily fragmented, causing problems, mostly in the SVG backend. This change combines all components of the metronome mark in one list before calling `make-concat-markup`. The make-simple-markup statements are also combined where possible, and comments have been added where characters can be confused. None have modified. This patch provides one part for the fix of bug 5174. Further patches will be needed to combine text of different styles/fonts or to fix text spacing in the SVG backend. Bug: 5174

Patch Set 1 #

Patch Set 2 : Fix list appending #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -22 lines) Patch
M scm/translation-functions.scm View 1 1 chunk +11 lines, -22 lines 0 comments Download

Messages

Total messages: 2
Ebe123
This patch provides one part for the fix of bug 5174. Further patches will be ...
6 years, 7 months ago (2017-09-02 21:33:07 UTC) #1
Ebe123
6 years, 7 months ago (2017-09-03 16:14:26 UTC) #2
Fix list appending
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b