Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(84)

Issue 3280042: FiguredBass: Extenders for figures of different width should still stop at the same position (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by Reinhold
Modified:
13 years, 4 months ago
Reviewers:
carl.d.sorensen, Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

FiguredBass: Extenders for figures of different width should still stop at the same position FB extenders use the extent of the hidden figure grob, so extenders of different figures might stop at different positions. Ideally, the note of the associated staff should be retrieved and used as the position to stop the extender. However, FB can also exist standalone without any attached staff. So, as a workaround, this patch simply sets the text of all (hidden) ending figures to 0, so they all have the same extent and all extenders will stop at the same position

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
A input/regression/figured-bass-continuation-end-position.ly View 1 chunk +18 lines, -0 lines 0 comments Download
M lily/figured-bass-engraver.cc View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 3
Carl
LGTM. Carl
13 years, 4 months ago (2010-11-24 15:46:19 UTC) #1
Neil Puttock
LGTM. http://codereview.appspot.com/3280042/diff/1/lily/figured-bass-engraver.cc File lily/figured-bass-engraver.cc (right): http://codereview.appspot.com/3280042/diff/1/lily/figured-bass-engraver.cc#newcode467 lily/figured-bass-engraver.cc:467: group.figure_item_->set_property ("text", ly_string2scm("0")); ly_string2scm ("0")
13 years, 4 months ago (2010-11-24 18:05:42 UTC) #2
Reinhold
13 years, 4 months ago (2010-11-25 15:38:48 UTC) #3
On 2010/11/24 18:05:42, Neil Puttock wrote:
> ly_string2scm("0"));
> ly_string2scm ("0")

Fixed and pushed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b