Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3041)

Issue 3270042: Assign separate GType to each m17n engine to make config per-class. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by Daiki Ueno
Modified:
13 years, 4 months ago
Reviewers:
shawn.p.huang
Base URL:
git@github.com:ibus/ibus-m17n.git@master
Visibility:
Public.

Description

Assign separate GType to each m17n engine to make config per-class. BUG=none TEST=manual

Patch Set 1 #

Total comments: 9

Patch Set 2 : Refactor engine_name/class_name/config_section handling. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -152 lines) Patch
M src/engine.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/engine.c View 1 11 chunks +286 lines, -147 lines 1 comment Download
M src/main.c View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 6
Daiki Ueno
13 years, 4 months ago (2010-12-01 01:29:59 UTC) #1
Peng
http://codereview.appspot.com/3270042/diff/1/src/engine.c File src/engine.c (right): http://codereview.appspot.com/3270042/diff/1/src/engine.c#newcode19 src/engine.c:19: }; Please explain why need implement a GTypeModule. http://codereview.appspot.com/3270042/diff/1/src/engine.c#newcode196 ...
13 years, 4 months ago (2010-12-01 03:31:41 UTC) #2
Daiki Ueno
http://codereview.appspot.com/3270042/diff/1/src/engine.c File src/engine.c (right): http://codereview.appspot.com/3270042/diff/1/src/engine.c#newcode19 src/engine.c:19: }; On 2010/12/01 03:31:41, Shawn.P.Huang wrote: > Please explain ...
13 years, 4 months ago (2010-12-01 05:15:29 UTC) #3
Peng
http://codereview.appspot.com/3270042/diff/1/src/engine.c File src/engine.c (right): http://codereview.appspot.com/3270042/diff/1/src/engine.c#newcode19 src/engine.c:19: }; On 2010/12/01 05:15:29, Daiki Ueno wrote: > On ...
13 years, 4 months ago (2010-12-01 06:03:28 UTC) #4
Daiki Ueno
I updated the patch set fixing the issues you pointed out, except GTypeModule thing (for ...
13 years, 4 months ago (2010-12-01 07:31:47 UTC) #5
Peng
13 years, 4 months ago (2010-12-01 07:36:44 UTC) #6
LGTM. Thanks.

http://codereview.appspot.com/3270042/diff/7001/src/engine.c
File src/engine.c (right):

http://codereview.appspot.com/3270042/diff/7001/src/engine.c#newcode393
src/engine.c:393: minput_close_im (klass->im);
Please release config_section too.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b