Issue 3269043: Do not call g_critical when ibus->config is NULL since it's not an error.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3269043: Do not call g_critical when ibus->config is NULL since it's not an error. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Yusuke Sato

Modified:
13 years, 7 months ago

Reviewers:
shawn.p.huang, Peng Huang, Peng

CC:
satorux

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Do not call g_critical when ibus->config is NULL since it's not an error. The change is originally for chromeos branch of ibus (http://codereview.appspot.com/3304043/) but I believe this is also good for the master branch of ibus. BUG=none TEST=manually

Patch Set 1 #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	bus/ibusimpl.c	View		2 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

13 years, 7 months ago (2010-11-29 02:32:46 UTC) #3

On 2010/11/29 01:37:15, Yusuke Sato wrote:
> ping? this is for the master branch.
LGTM.

Expand All Messages | Collapse All Messages