Issue 3264041: add rule for naming type/function/variable to the coding standards

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3264041: add rule for naming type/function/variable to the coding standards

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by wan

Modified:
14 years ago

Reviewers:
chandlerc

Base URL:
https://llvm.org/svn/llvm-project/llvm/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : add an exception about short local variable names #

Patch Set 3 : addresses Chris' comments. #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -0 lines)			Patch
	M	docs/CodingStandards.html	View	1 2	2 chunks	+67 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

chandlerc

14 years ago (2010-11-23 05:27:58 UTC) #1

http://codereview.appspot.com/3264041/diff/1/docs/CodingStandards.html
File docs/CodingStandards.html (right):

http://codereview.appspot.com/3264041/diff/1/docs/CodingStandards.html#newcod...
docs/CodingStandards.html:801: camel case (e.g. <tt>TextFileReader</tt> and
<tt>isLValue</tt>).
I would really prefer some stylistic difference between variables and
types/functions. This is mostly a problem (for me) with local variables, where
having some signifier of the locality helps me in reading it.

The most common style I have worked with is to use under_score_separators for
variables. Personally, I would advocate for sharing this style with member
variables as well, but those aren't as important to me when reading code.

Expand All Messages | Collapse All Messages