Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2507)

Issue 325630043: Adapt lilypond to ghostscript 9.22, change command line options

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by knupero
Modified:
6 years, 6 months ago
Reviewers:
wl, carl.d.sorensen, Karlin High, dak, pkx166h, trueroad
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

We need to adapt lilypond to ghostscript 9.22 as our old --bigpdf parameter is broken by the new version of gs. --bigpdf is totally removed. --pspdfopt=(size/TeX/TeX-GS) is implemented to allow the user to select the appropiate set of -d... parameters for different purposes. The patch also contains some minor fixes of related bugs, introduces --eps to the command line interface and changes the bug-report message as post.gmane is gone. Signed-off-by: Knut Petersen <knut_petersen@t-online.de>

Patch Set 1 #

Total comments: 1

Patch Set 2 : kill --bigpdfs, introduce --use-encodings, remove code not needed by ghostscript 9.20+ #

Patch Set 3 : introduce --pdfsizeopt=size, TeX or TeX-GS, no --bigpdf, no --use-encodings #

Patch Set 4 : fix --eps, change bug report msg, fix documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -130 lines) Patch
M Documentation/de/usage/running.itely View 1 2 3 3 chunks +17 lines, -32 lines 0 comments Download
M Documentation/usage/running.itely View 1 2 3 3 chunks +16 lines, -32 lines 0 comments Download
M lily/general-scheme.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M lily/global-vars.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M lily/include/main.hh View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M lily/main.cc View 1 2 3 6 chunks +42 lines, -18 lines 0 comments Download
M make/lilypond-vars.make View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M make/lysdoc-targets.make View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ps/encodingdefs.ps View 1 1 chunk +1 line, -1 line 0 comments Download
M scm/backend-library.scm View 1 1 chunk +0 lines, -1 line 0 comments Download
M scm/framework-ps.scm View 1 2 5 chunks +4 lines, -29 lines 0 comments Download
M scm/lily.scm View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M scm/output-ps.scm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 41
dak
https://codereview.appspot.com/325630043/diff/1/make/lilypond-vars.make File make/lilypond-vars.make (right): https://codereview.appspot.com/325630043/diff/1/make/lilypond-vars.make#newcode54 make/lilypond-vars.make:54: -dgs-never-embed-fonts -b Is there a conceivable application for using ...
6 years, 6 months ago (2017-09-23 16:02:32 UTC) #1
knupero
On 2017/09/23 16:02:32, dak wrote: > https://codereview.appspot.com/325630043/diff/1/make/lilypond-vars.make > File make/lilypond-vars.make (right): > > https://codereview.appspot.com/325630043/diff/1/make/lilypond-vars.make#newcode54 > ...
6 years, 6 months ago (2017-09-23 16:22:58 UTC) #2
trueroad
`-dgs-never-embed-fonts` doesn't effect for TrueType fonts. Therefore, when both `-dgs-never-embed-fonts` and `--bigpdfs`/`-b` are used at ...
6 years, 6 months ago (2017-09-23 16:49:14 UTC) #3
knupero
> Combining them means that the size of the final PDF may be smaller but ...
6 years, 6 months ago (2017-09-24 00:25:17 UTC) #4
trueroad
On 2017/09/24 00:25:17, knupero wrote: > > If I understand correctly, `--bigpdfs` / `-b` has ...
6 years, 6 months ago (2017-09-24 10:05:43 UTC) #5
dak
On 2017/09/24 10:05:43, trueroad wrote: > On 2017/09/24 00:25:17, knupero wrote: > > > If ...
6 years, 6 months ago (2017-09-24 11:03:26 UTC) #6
trueroad
On 2017/09/24 11:03:26, dak wrote: > In my opinion, -b/--bigpdf should be simple to use ...
6 years, 6 months ago (2017-09-24 14:32:02 UTC) #7
Carl
On 2017/09/24 14:32:02, trueroad wrote: > * -dgs-neverembed-fonts > > Add behavior > > Current ...
6 years, 6 months ago (2017-09-25 00:44:48 UTC) #8
knupero
kill --bigpdfs, introduce --use-encodings, remove code not needed by ghostscript 9.20+
6 years, 6 months ago (2017-09-25 12:13:34 UTC) #9
knupero
A bit more far-reaching. As newer versions of gs - don't need the helpemmentaler functions ...
6 years, 6 months ago (2017-09-25 12:54:24 UTC) #10
knupero
6 years, 6 months ago (2017-09-25 12:54:47 UTC) #11
dak
On 2017/09/25 12:13:34, knupero wrote: > kill --bigpdfs, introduce --use-encodings, remove code not needed by ...
6 years, 6 months ago (2017-09-25 13:21:44 UTC) #12
dak
On 2017/09/25 12:54:24, knupero wrote: > A bit more far-reaching. > > As newer versions ...
6 years, 6 months ago (2017-09-25 13:41:16 UTC) #13
trueroad
On 2017/09/25 13:21:44, dak wrote: > I don't really have a clue here: can someone ...
6 years, 6 months ago (2017-09-25 14:50:09 UTC) #14
knupero
> > --use-encodings switches emmentaler glyph generation from "glyphshow" to > > "show"+encodings and might ...
6 years, 6 months ago (2017-09-25 16:38:16 UTC) #15
knupero
> I don't really have a clue here: can someone chime in with the current ...
6 years, 6 months ago (2017-09-25 16:45:33 UTC) #16
dak
Why are we still navigating the bleeding edge? LilyPond is more than 20 years old. ...
6 years, 6 months ago (2017-09-25 17:33:47 UTC) #17
knupero
On 2017/09/25 17:33:47, dak wrote: > Why are we still navigating the bleeding edge? LilyPond ...
6 years, 6 months ago (2017-09-25 22:17:41 UTC) #18
dak
On 2017/09/25 22:17:41, knupero wrote: > On 2017/09/25 17:33:47, dak wrote: > > I see. ...
6 years, 6 months ago (2017-09-26 11:40:44 UTC) #19
knupero
> > Remember: We used the hardcoded name "Emmentaler" at various places > > for ...
6 years, 6 months ago (2017-09-26 20:26:36 UTC) #20
dak
On 2017/09/26 20:26:36, knupero wrote: > > > Regarding the naming of the option, I'd ...
6 years, 6 months ago (2017-09-26 22:19:27 UTC) #21
Karlin High
On 2017/09/26 22:19:27, dak wrote: > > If you know a better name for the ...
6 years, 6 months ago (2017-09-27 02:17:16 UTC) #22
wl_gnu.org
> Somehow, concisely say "get-rid-of-anything-extra" versus > "keep-everything-that-comes?" > > --min-fonts and --max-fonts > --compress-fonts ...
6 years, 6 months ago (2017-09-27 04:55:31 UTC) #23
pkx166h
On 2017/09/27 04:55:31, wl_gnu.org wrote: > > Somehow, concisely say "get-rid-of-anything-extra" versus > > "keep-everything-that-comes?" ...
6 years, 6 months ago (2017-09-27 06:59:25 UTC) #24
dak
Werner LEMBERG <wl@gnu.org> writes: >> Somehow, concisely say "get-rid-of-anything-extra" versus >> "keep-everything-that-comes?" >> >> --min-fonts ...
6 years, 6 months ago (2017-09-27 07:24:34 UTC) #25
knupero
> Bikeshedding done for the day. Let me continue. "lilypond --help" and "lilypond -dhelp" gives ...
6 years, 6 months ago (2017-09-27 09:38:21 UTC) #26
dak
On 2017/09/27 09:38:21, knupero wrote: > > Bikeshedding done for the day. > > Let ...
6 years, 6 months ago (2017-09-27 11:22:31 UTC) #27
knupero
> How about just --pdf=<purpose> ? One option less to remember. This is going to ...
6 years, 6 months ago (2017-09-27 11:49:51 UTC) #28
dak
On 2017/09/27 11:49:51, knupero wrote: > > How about just --pdf=<purpose> ? One option less ...
6 years, 6 months ago (2017-09-27 12:16:44 UTC) #29
knupero
introduce --pdfsizeopt=size, TeX or TeX-GS, no --bigpdf, no --use-encodings
6 years, 6 months ago (2017-09-27 22:49:24 UTC) #30
knupero
lilypond --help gives the following output: Usage: lilypond [OPTION]... FILE... Typeset music and/or produce MIDI ...
6 years, 6 months ago (2017-09-27 22:52:30 UTC) #31
wl_gnu.org
> lilypond --help gives the following output: [...] > -O, --pspdfopt=KEY set ps/pdf optimization to ...
6 years, 6 months ago (2017-09-28 05:00:41 UTC) #32
dak
Werner LEMBERG <wl@gnu.org> writes: >> lilypond --help gives the following output: [...] > >> -O, ...
6 years, 6 months ago (2017-09-28 06:16:39 UTC) #33
knupero
fix --eps, change bug report msg, fix documentation
6 years, 6 months ago (2017-09-28 10:15:26 UTC) #34
knupero
> BTW, is there any chance to reduce the width of the help screen to ...
6 years, 6 months ago (2017-09-28 10:19:13 UTC) #35
knupero
> While we are at it, it may make sense not to refer to the ...
6 years, 6 months ago (2017-09-28 10:26:05 UTC) #36
dak
On 2017/09/28 10:26:05, knupero wrote: > > While we are at it, it may make ...
6 years, 6 months ago (2017-09-28 11:04:03 UTC) #37
trueroad
LGTM For the future, I would like to prefer Identity-H encoding rather than 3 custom ...
6 years, 6 months ago (2017-09-29 12:01:41 UTC) #38
pkx166h
On 2017/09/28 11:04:03, dak wrote: > On 2017/09/28 10:26:05, knupero wrote: > > > While ...
6 years, 6 months ago (2017-10-03 13:54:26 UTC) #39
pkx166h
On 2017/09/29 12:01:41, trueroad wrote: > LGTM > > > For the future, I would ...
6 years, 6 months ago (2017-10-03 13:55:30 UTC) #40
knupero
6 years, 6 months ago (2017-10-04 17:09:52 UTC) #41
> > Unfortunately, non-CID-keyed fonts can not use Identity-H encoding.
> > XeTeX and LuaTeX seem to convert non-CID-Keyed font to CID-keyed font on the
> > fly, and embed it to PDF, use Identity-H encoding.
> 
> Should we create a tracker for this?

I think whoever has an idea and the time to solve one of the remaining
postscript problems will create a tracker.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b