http://codereview.appspot.com/3247/diff/1/3 File lib2to3/tests/support.py (right): http://codereview.appspot.com/3247/diff/1/3#newcode42 Line 42: def get_refactorer(fixers=None, options={}): using {} as a default ...
16 years, 8 months ago
(2008-09-02 05:46:23 UTC)
#2
http://codereview.appspot.com/3247/diff/1/3
File lib2to3/tests/support.py (right):
http://codereview.appspot.com/3247/diff/1/3#newcode42
Line 42: def get_refactorer(fixers=None, options={}):
using {} as a default arg is dangerous. in this case you just pass it to
RefactoringTool which as its currently written copies things out of it rather
than keeping a reference and modifying it. But that could change. Please
change the default to None and add a docstring mentioning that it should be a
dictionary.
Issue 3247: 2to3 refactoring
(Closed)
Created 16 years, 8 months ago by Benjamin
Modified 15 years, 9 months ago
Reviewers: gpshead
Base URL: http://svn.python.org/view/*checkout*/sandbox/trunk/2to3/
Comments: 1