Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(166)

Issue 3247: 2to3 refactoring (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 8 months ago by Benjamin
Modified:
14 years, 9 months ago
Reviewers:
gpshead
Base URL:
http://svn.python.org/view/*checkout*/sandbox/trunk/2to3/
Visibility:
Public.

Description

Moves cmdline processing logic out of RefactoringTool and into its own module lib2to3.main. See issue #3637.

Patch Set 1 #

Patch Set 2 : take Greg's advice (thanks!) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -170 lines) Patch
2to3 View 1 1 chunk +2 lines, -3 lines 0 comments Download
lib2to3/fixer_base.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
lib2to3/main.py View 1 chunk +86 lines, -0 lines 0 comments Download
lib2to3/refactor.py View 1 15 chunks +97 lines, -142 lines 0 comments Download
lib2to3/tests/support.py View 1 2 chunks +16 lines, -0 lines 0 comments Download
lib2to3/tests/test_all_fixers.py View 1 1 chunk +2 lines, -9 lines 0 comments Download
lib2to3/tests/test_fixers.py View 1 2 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 3
Benjamin
15 years, 8 months ago (2008-08-21 20:44:46 UTC) #1
gregory.p.smith
http://codereview.appspot.com/3247/diff/1/3 File lib2to3/tests/support.py (right): http://codereview.appspot.com/3247/diff/1/3#newcode42 Line 42: def get_refactorer(fixers=None, options={}): using {} as a default ...
15 years, 7 months ago (2008-09-02 05:46:23 UTC) #2
Benjamin
15 years, 7 months ago (2008-09-02 22:19:46 UTC) #3
take Greg's advice (thanks!)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b