Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1185)

Issue 323940043: Various chain-assoc-get -> #:properties (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by dak
Modified:
5 years, 8 months ago
Reviewers:
thomasmorley651, carl.d.sorensen, Carl
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Various chain-assoc-get -> #:properties Also contains commits: three-sided-box snippet: use #:properties keyword Run scripts/auxiliar/makelsr.py

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove tab #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -37 lines) Patch
M Documentation/snippets/analysis-brackets-with-labels.ly View 1 chunk +4 lines, -4 lines 0 comments Download
A + Documentation/snippets/new/three-sided-box.ly View 1 3 chunks +4 lines, -13 lines 2 comments Download
M Documentation/snippets/three-sided-box.ly View 1 2 chunks +10 lines, -11 lines 0 comments Download
M ly/toc-init.ly View 1 chunk +2 lines, -1 line 0 comments Download
M scm/define-markup-commands.scm View 4 chunks +6 lines, -7 lines 0 comments Download
M scm/harp-pedals.scm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
thomasmorley651
LGTM one nit: https://codereview.appspot.com/323940043/diff/1/Documentation/snippets/three-sided-box.ly File Documentation/snippets/three-sided-box.ly (right): https://codereview.appspot.com/323940043/diff/1/Documentation/snippets/three-sided-box.ly#newcode45 Documentation/snippets/three-sided-box.ly:45: (m (interpret-markup layout props arg))) tab->spaces
6 years, 9 months ago (2017-06-16 09:36:15 UTC) #1
dak
Remove tab
6 years, 9 months ago (2017-06-16 10:44:37 UTC) #2
Carl
LGTM. One small possible change. https://codereview.appspot.com/323940043/diff/20001/Documentation/snippets/new/three-sided-box.ly File Documentation/snippets/new/three-sided-box.ly (right): https://codereview.appspot.com/323940043/diff/20001/Documentation/snippets/new/three-sided-box.ly#newcode36 Documentation/snippets/new/three-sided-box.ly:36: (let* ((pad (* (magstep ...
6 years, 9 months ago (2017-06-16 21:59:49 UTC) #3
dak
6 years, 9 months ago (2017-06-17 06:38:58 UTC) #4
https://codereview.appspot.com/323940043/diff/20001/Documentation/snippets/ne...
File Documentation/snippets/new/three-sided-box.ly (right):

https://codereview.appspot.com/323940043/diff/20001/Documentation/snippets/ne...
Documentation/snippets/new/three-sided-box.ly:36: (let* ((pad (* (magstep
font-size) box-padding))
On 2017/06/16 21:59:49, Carl wrote:
> Looks like this could now be a let instead of let*

Done.  Not going to create a new review for it though.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b