Issue 3233041: [PATCH] Use the definition's source location even for already-instantiated templates (PR c++/46527)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3233041: [PATCH] Use the definition's source location even for already-instantiated templates (PR c++/46527) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by Jeffrey Yasskin (google)

Modified:
14 years, 1 month ago

Reviewers:
Diego Novillo

CC:
gcc-patches_gcc.gnu.org

Base URL:
svn://gcc.gnu.org/svn/gcc/trunk/

Visibility:
Public.

Description

This patch propagates the source location from a template function's definition to any already-instantiated declarations. It doesn't also copy it to the template_decl, even though that also has the wrong location, because maybe that's supposed to represent the declaration and not the definition. PR c++/46527 * gcc/cp/pt.c (instantiate_decl): Propagate the template's location to its instance. * gcc/testsuite/g++.dg/debug/dwarf2/pr46527.C: New.

Patch Set 1 #

Patch Set 2 : Now with a test #

Total comments: 1

Patch Set 3 : Add a space #

Patch Set 4 : Update the template_decl's location too. #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	M	gcc/cp/pt.c	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
	A	gcc/testsuite/g++.dg/debug/dwarf2/pr46527.C	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Diego Novillo

14 years, 1 month ago (2010-11-20 05:40:09 UTC) #1

As we discussed, it seems reasonable, but I don't know this area very well. 
Jason should give you a definitive answer.

http://codereview.appspot.com/3233041/diff/2001/gcc/cp/pt.c
File gcc/cp/pt.c (right):

http://codereview.appspot.com/3233041/diff/2001/gcc/cp/pt.c#newcode17155
gcc/cp/pt.c:17155: DECL_SOURCE_LOCATION (d) =
DECL_SOURCE_LOCATION(code_pattern);
space before '('.

Expand All Messages | Collapse All Messages