Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12877)

Issue 32148: Move left-broken line-spanner check to callback. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by Neil Puttock
Modified:
14 years, 8 months ago
Reviewers:
joeneeman
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Move left-broken line-spanner check to callback. Currently, left-broken line spanners and hairpins are removed when they end on the first note of the new system. Though this is appropriate for glissandi and voice followers, there is no way to override this default behaviour. This patch allows the user to tweak the appearance by overriding 'after-line-breaking. - removed left-broken check from ly:line-spanner::print to a new after-line-breaking callback, ly:spanner::after-line-breaking - removed hairpin after-line-breaking callback and associated method consider_suicide () - added new callback to Hairpin, Glissando and VoiceFollower

Patch Set 1 #

Total comments: 1

Patch Set 2 : Name change for callback & convert rule for hairpin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -83 lines) Patch
M Documentation/de/user/input.itely View 1 chunk +2 lines, -3 lines 0 comments Download
M Documentation/user/input.itely View 1 chunk +1 line, -2 lines 0 comments Download
A input/regression/spanner-after-line-breaking.ly View 1 1 chunk +36 lines, -0 lines 0 comments Download
M lily/hairpin.cc View 2 chunks +1 line, -37 lines 0 comments Download
M lily/include/hairpin.hh View 1 chunk +0 lines, -2 lines 0 comments Download
M lily/include/spanner.hh View 1 1 chunk +1 line, -0 lines 0 comments Download
M lily/line-spanner.cc View 3 chunks +0 lines, -22 lines 0 comments Download
M lily/spanner.cc View 1 9 chunks +34 lines, -14 lines 0 comments Download
M python/convertrules.py View 1 chunk +3 lines, -1 line 0 comments Download
M scm/define-grobs.scm View 1 4 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4
joeneeman
One minor comment, otherwise lgtm http://codereview.appspot.com/32148/diff/1/7 File lily/spanner.cc (right): http://codereview.appspot.com/32148/diff/1/7#newcode426 Line 426: Spanner::after_line_breaking (SCM grob) ...
15 years ago (2009-04-08 20:42:51 UTC) #1
Neil Puttock
On 2009/04/08 20:42:51, joeneeman wrote: > http://codereview.appspot.com/32148/diff/1/7#newcode426 > Line 426: Spanner::after_line_breaking (SCM grob) > Can ...
15 years ago (2009-04-11 12:31:10 UTC) #2
joeneeman
On 2009/04/11 12:31:10, Neil Puttock wrote: > On 2009/04/08 20:42:51, joeneeman wrote: > > http://codereview.appspot.com/32148/diff/1/7#newcode426 ...
15 years ago (2009-04-11 19:22:54 UTC) #3
Neil Puttock
15 years ago (2009-04-13 14:41:05 UTC) #4
On 2009/04/11 19:22:54, joeneeman wrote:

> I prefer the second one.

OK, ly:spanner::kill-zero-spanned-time it is.

I've added a convert rule just in case anybody's using
ly:hairpin::after-line-breaking.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b