Issue 32142: Fix #670: Chained trills

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 32142: Fix #670: Chained trills (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by Neil Puttock

Modified:
14 years, 9 months ago

Reviewers:
joeneeman

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix #670: Chained trills - if trill spanner isn't stopped using \stopTrillSpan, make next start-span right bound. - for trill spans on last note of final system, don't end on final musical column, since it will extend beyond the last breakable column.

Patch Set 1 #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -36 lines)			Patch
A	input/regression/trill-spanner-auto-stop.ly	View	1 chunk	+15 lines, -0 lines	0 comments	Download
A	input/regression/trill-spanner-chained.ly	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	lily/trill-spanner-engraver.cc	View	5 chunks	+33 lines, -36 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Neil Puttock

15 years ago (2009-04-11 12:13:51 UTC) #2

On 2009/04/08 20:37:56, joeneeman wrote:
> lgtm

Cheers.

I've amended trill-spanner-auto-stop.ly since there's a rogue space after @code.

Expand All Messages | Collapse All Messages