Issue 32132: Simplify preloader API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 32132: Simplify preloader API (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 5 months ago by awiner

Modified:
16 years, 1 month ago

Reviewers:
shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

Now that data pipelining isn't a Preloader, preloading is ripe for a bit of simplification. This removes support for binding a List of Preloaders, makes Preloader @ImplementedBy HttpPreloader, and removes the concept of preload phases.

Patch Set 1 #

Patch Set 2 : Further simplify, and eliminate JSONObject/JSONArray typing+casting #

Created: 16 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+187 lines, -184 lines)			Patch
M	java/common/src/main/java/org/apache/shindig/common/JsonSerializer.java	View		3 chunks	+37 lines, -1 line	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/ConcurrentPreloaderService.java	View	1	3 chunks	+6 lines, -19 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/HttpPreloader.java	View	1	1 chunk	+5 lines, -8 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/PipelineExecutor.java	View		4 chunks	+20 lines, -18 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/PipelinedDataPreloader.java	View		5 chunks	+33 lines, -17 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/PreloadModule.java	View	1	2 chunks	+0 lines, -20 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/Preloader.java	View	1	1 chunk	+4 lines, -6 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/PreloaderService.java	View	1	1 chunk	+1 line, -16 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/render/HtmlRenderer.java	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/render/ProxyRenderer.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java	View		3 chunks	+5 lines, -7 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/PipelineDataContentRewriter.java	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateContext.java	View		3 chunks	+2 lines, -5 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/preload/ConcurrentPreloaderServiceTest.java	View	1	7 chunks	+10 lines, -14 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/preload/HttpPreloaderTest.java	View	1	6 chunks	+5 lines, -24 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/preload/PipelineExecutorTest.java	View		7 chunks	+14 lines, -17 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/preload/PipelinedDataPreloaderTest.java	View		1 chunk	+33 lines, -0 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/render/HtmlRendererTest.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/render/ProxyRendererTest.java	View		4 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages