Issue 32117: Fixing some windows issues

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 32117: Fixing some windows issues

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years ago by Antoine Labour

Modified:
10 years, 4 months ago

Reviewers:
Eric U.

CC:
nixysa-users_googlegroups.com

Base URL:
http://nixysa.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 16 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+465 lines, -10 lines)			Patch
M	examples/complex/README	View	1 chunk	+6 lines, -3 lines	1 comment	Download
M	examples/complex/SConstruct	View	2 chunks	+6 lines, -3 lines	0 comments	Download
A	examples/complex/complex.def	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	examples/complex/complex.rc	View	1 chunk	+102 lines, -0 lines	0 comments	Download
A	examples/complex/complex.sln	View	1 chunk	+20 lines, -0 lines	0 comments	Download
A	examples/complex/complex.vcproj	View	1 chunk	+299 lines, -0 lines	0 comments	Download
M	examples/complex/plugin.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	examples/complex/resource.h	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	nixysa/codegen.bat	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	nixysa/static_glue/npapi/main.cc	View	3 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Antoine Labour

This CL adds a solution and project for Windows users, and fixes a couple of ...

16 years ago (2009-04-03 07:16:14 UTC) #1

Eric U.

LGTM; just one comment fix. Eric http://codereview.appspot.com/32117/diff/1/10 File examples/complex/README (right): http://codereview.appspot.com/32117/diff/1/10#newcode8 Line 8: plug-in automatically, ...

16 years ago (2009-04-03 21:46:23 UTC) #2

Antoine Labour

16 years ago (2009-04-03 22:12:38 UTC) #3

On 2009/04/03 21:46:23, Eric U. wrote:
> LGTM; just one comment fix.
> 
> 	Eric
> 
> http://codereview.appspot.com/32117/diff/1/10
> File examples/complex/README (right):
> 
> http://codereview.appspot.com/32117/diff/1/10#newcode8
> Line 8: plug-in automatically, run Firefox and load the sample page.
> If it's going to run Firefox automatically, you want a comma after Firefox. 
If
> that's something the user has to do, change the comma before run to a
semicolon.

Fixed, and submitted.

Expand All Messages | Collapse All Messages