Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(53)

Issue 320800043: Let configure find all needed files with guile-2.2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 1 month ago by thomasmorley651
Modified:
6 years, 12 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Let configure find all needed files with guile-2.2 in configure.ac Adds support for STEPMAKE_GUILE Update guile-versions for STEPMAKE_GUILE and STEPMAKE_GUILE_DEVEL in aclocal.m4 update the list to search for guile-config Many thanks to Antonio Ospite

Patch Set 1 #

Patch Set 2 : fix indentation, comment #

Total comments: 2

Patch Set 3 : Werner's comment #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M aclocal.m4 View 1 2 1 chunk +6 lines, -1 line 2 comments Download
M configure.ac View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7
thomasmorley651
This is needed to compile LilyPond with guile-2.2.x Please review.
7 years, 1 month ago (2017-03-28 09:58:21 UTC) #1
thomasmorley651
fix indentation, comment
7 years, 1 month ago (2017-03-28 10:05:19 UTC) #2
lemzwerg
LGTM https://codereview.appspot.com/320800043/diff/20001/aclocal.m4 File aclocal.m4 (right): https://codereview.appspot.com/320800043/diff/20001/aclocal.m4#newcode661 aclocal.m4:661: for r in $GUILE_CONFIG $target_guile_config $host_guile_config $build_guile_config guile-config ...
7 years, 1 month ago (2017-03-28 10:18:50 UTC) #3
thomasmorley651
Werner's comment
7 years, 1 month ago (2017-03-28 12:50:22 UTC) #4
thomasmorley651
https://codereview.appspot.com/320800043/diff/20001/aclocal.m4 File aclocal.m4 (right): https://codereview.appspot.com/320800043/diff/20001/aclocal.m4#newcode661 aclocal.m4:661: for r in $GUILE_CONFIG $target_guile_config $host_guile_config $build_guile_config guile-config guile-2.2-config ...
7 years, 1 month ago (2017-03-28 12:53:55 UTC) #5
lemzwerg
https://codereview.appspot.com/320800043/diff/40001/aclocal.m4 File aclocal.m4 (right): https://codereview.appspot.com/320800043/diff/40001/aclocal.m4#newcode666 aclocal.m4:666: do Just curious: What's the reason to have 1 ...
7 years, 1 month ago (2017-03-28 13:35:52 UTC) #6
thomasmorley651
7 years, 1 month ago (2017-03-28 15:04:47 UTC) #7
https://codereview.appspot.com/320800043/diff/40001/aclocal.m4
File aclocal.m4 (right):

https://codereview.appspot.com/320800043/diff/40001/aclocal.m4#newcode666
aclocal.m4:666: do
On 2017/03/28 13:35:51, lemzwerg wrote:
> Just curious: What's the reason to have 1 - 1.9 - 1.8 - 1 - 1.9 - 1.8 as the
> order of the last elements?
> 
> I would have expected  1.9 - 1.9 - 1.8 - 1.8 - 1 - 1 instead.

Tbh, I've no clue.

To help moving LilyPond to guile-2.x I plan to tackle uncontroversal things
first. All those low hanging fruits or already fallen down to the ground, just
picking them up. So that those annoying warnings about deprecated this and that
are out of the way, etc

Though, without this one in master testings with guile-2.2.x are unconvenient.

Actually I've put in guile-2-configs where it workes, but didn't even try to
improve anything else.

Maybe someone else can answer.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b