Histogram chart is mostly whitespace

Create a new chart package and move existing charting code there.

Make a new histogram chart. The old one was a waste of real estate, and didn't show the bad classes at all. This new chart is rendered by the app, rather than using Google charts API (as requested by a user). The Y axis is logarithmic, so one or two classes with a high score still show prominently. Doesn't do the green/yellow/red in the graph like the old one did.

[Shyam, 2009-03-31 04:57:25]

LGTM. Fix and submit.

http://codereview.appspot.com/32071/diff/1/22
File
core/src/main/java/com/google/test/metric/report/chart/CostDistributionChart.java
(right):

http://codereview.appspot.com/32071/diff/1/22#newcode1
Line 1: package com.google.test.metric.report.chart;
any copyright comments needed ?

http://codereview.appspot.com/32071/diff/1/3
File core/src/main/java/com/google/test/metric/report/chart/GoodnessChart.java
(right):

http://codereview.appspot.com/32071/diff/1/3#newcode2
Line 2: * Copyright 2007 Google Inc.
year ?

http://codereview.appspot.com/32071/diff/1/3#newcode18
Line 18: public class GoodnessChart extends GoogleChartAPI {
why not use jfreechart or googlechartapi for all ? or is that the plan, but ur
doing it in iterations ?

http://codereview.appspot.com/32071/diff/1/18
File core/src/main/java/com/google/test/metric/report/chart/Histogram.java
(right):

http://codereview.appspot.com/32071/diff/1/18#newcode22
Line 22: public class Histogram {
i'm assuming all of these are just moves into this package ?

http://codereview.appspot.com/32071/diff/1/33
File
core/src/main/java/com/google/test/metric/report/chart/IntegerTickUnitSource.java
(right):

http://codereview.appspot.com/32071/diff/1/33#newcode1
Line 1: package com.google.test.metric.report.chart;
copyrihgt

http://codereview.appspot.com/32071/diff/1/33#newcode20
Line 20: double x = unit.getSize();
indentation seems off in tbis file

http://codereview.appspot.com/32071/diff/1/30
File core/src/main/java/com/google/test/metric/report/chart/PieGraph.java
(right):

http://codereview.appspot.com/32071/diff/1/30#newcode4
Line 4: /*
move to the top. update year in all of em

http://codereview.appspot.com/32071/diff/1/6
File core/src/main/java/com/google/test/metric/report/html/HtmlReport.java
(right):

http://codereview.appspot.com/32071/diff/1/6#newcode59
Line 59: public String getHistogram() {
is this still a histogram ?

http://codereview.appspot.com/32071/diff/1/21
File
core/src/test/java/com/google/test/metric/report/chart/CostDistributionChartTest.java
(right):

http://codereview.appspot.com/32071/diff/1/21#newcode1
Line 1: package com.google.test.metric.report.chart;
copyright

http://codereview.appspot.com/32071/diff/1/21#newcode17
Line 17: protected void setUp() throws Exception {
get rid of it, its useless

http://codereview.appspot.com/32071/diff/1/21#newcode21
Line 21: public void testCreateChart() throws Exception {
is this test even testing anything ? delete or revert if no asseerts

[Alex, 2009-03-31 05:27:34]

Thanks for the review

http://codereview.appspot.com/32071/diff/1/22
File
core/src/main/java/com/google/test/metric/report/chart/CostDistributionChart.java
(right):

http://codereview.appspot.com/32071/diff/1/22#newcode1
Line 1: package com.google.test.metric.report.chart;
On 2009/03/31 04:57:25, Shyam wrote:
> any copyright comments needed ?

Done.

http://codereview.appspot.com/32071/diff/1/3
File core/src/main/java/com/google/test/metric/report/chart/GoodnessChart.java
(right):

http://codereview.appspot.com/32071/diff/1/3#newcode2
Line 2: * Copyright 2007 Google Inc.
On 2009/03/31 04:57:25, Shyam wrote:
> year ?

this is just a move (too bad the code review tool doesn't say so.. maybe if I
used the python uploader?)

http://codereview.appspot.com/32071/diff/1/3#newcode18
Line 18: public class GoodnessChart extends GoogleChartAPI {
On 2009/03/31 04:57:25, Shyam wrote:
> why not use jfreechart or googlechartapi for all ? or is that the plan, but ur
> doing it in iterations ?

Yes, I think I ought to replace them all, good point. I need to get a handle on
all the graphs in the current codebase and do some more refactors probably.

http://codereview.appspot.com/32071/diff/1/18
File core/src/main/java/com/google/test/metric/report/chart/Histogram.java
(right):

http://codereview.appspot.com/32071/diff/1/18#newcode22
Line 22: public class Histogram {
On 2009/03/31 04:57:25, Shyam wrote:
> i'm assuming all of these are just moves into this package ?

yup, just moves

http://codereview.appspot.com/32071/diff/1/33
File
core/src/main/java/com/google/test/metric/report/chart/IntegerTickUnitSource.java
(right):

http://codereview.appspot.com/32071/diff/1/33#newcode1
Line 1: package com.google.test.metric.report.chart;
On 2009/03/31 04:57:25, Shyam wrote:
> copyrihgt

not actually using this class anymore.

http://codereview.appspot.com/32071/diff/1/6
File core/src/main/java/com/google/test/metric/report/html/HtmlReport.java
(right):

http://codereview.appspot.com/32071/diff/1/6#newcode59
Line 59: public String getHistogram() {
On 2009/03/31 04:57:25, Shyam wrote:
> is this still a histogram ?

yes, it still is - histogram shows the distribution

http://codereview.appspot.com/32071/diff/1/21
File
core/src/test/java/com/google/test/metric/report/chart/CostDistributionChartTest.java
(right):

http://codereview.appspot.com/32071/diff/1/21#newcode1
Line 1: package com.google.test.metric.report.chart;
On 2009/03/31 04:57:25, Shyam wrote:
> copyright

Done.

http://codereview.appspot.com/32071/diff/1/21#newcode17
Line 17: protected void setUp() throws Exception {
On 2009/03/31 04:57:25, Shyam wrote:
> get rid of it, its useless

Done.

http://codereview.appspot.com/32071/diff/1/21#newcode21
Line 21: public void testCreateChart() throws Exception {
On 2009/03/31 04:57:25, Shyam wrote:
> is this test even testing anything ? delete or revert if no asseerts

it's mostly to make sure it doesn't throw exceptions, then the resulting chart
has to be manually inspected. Added asserts that the file is created and has
size > 1