Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(47)

Issue 32044: Fixes to the OSML spec

Can't Edit
Can't Publish+Mail
Start Review
Created:
17 years, 3 months ago by levik
Modified:
17 years, 3 months ago
Reviewers:
♫ opensocial-and-gadgets-spec, awiner, Evan Gilbert (code review)
Base URL:
http://opensocial-resources.googlecode.com/svn/spec/
Visibility:
Public.

Description

- Removed <os:Get>. - Added reasoning for its removal w/ suggested workaround - Added note on <script> tags - Added <script> tags to examples - Made Proxied render use case more detailed

Patch Set 1 #

Total comments: 9

Patch Set 2 : Updated based on comments/discussions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -51 lines) Patch
M draft/OpenSocial-Markup-Language-Tags.xml View 1 7 chunks +81 lines, -51 lines 0 comments Download

Messages

Total messages: 2
awiner
http://codereview.appspot.com/32044/diff/1/2 File draft/OpenSocial-Markup-Language-Tags.xml (left): http://codereview.appspot.com/32044/diff/1/2#oldcode61 Line 61: Inline tag to show a person's name, linked ...
17 years, 3 months ago (2009-03-27 00:26:17 UTC) #1
Evan Gilbert (code review)
17 years, 3 months ago (2009-03-27 00:54:35 UTC) #2
http://codereview.appspot.com/32044/diff/1/2
File draft/OpenSocial-Markup-Language-Tags.xml (right):

http://codereview.appspot.com/32044/diff/1/2#newcode83
Line 83: <t>@person {string|Object} The person object or DataContext key
referring to a
On 2009/03/27 00:26:17, awiner wrote:
> Think this should always be a Person object.
> Supporting a DataContext key just saves you the ${} braces.

Agree with Adam on this.

http://codereview.appspot.com/32044/diff/1/2#newcode109
Line 109: <t>@onselect {string|function} Client side script function to invoke
when a person
On 2009/03/27 00:26:17, awiner wrote:
> what can the script do?  what arguments does it take?  When is it called for
> multiple selection?  We might punt this out of the spec and make it a
container
> extension, or we can try fully specifying it.

Think the callback should be either:
1. callback(idsOfPeople) or
2. callback(listOfPeopleObjects)

#1 probably makes sense given server side rendering - you don't want to have to
keep the people around. But #2 would make it easier to do something with the
selected people without looking them up.

http://codereview.appspot.com/32044/diff/1/2#newcode218
Line 218: <t>Then use ${Data} in your template.</t>
On 2009/03/27 00:26:17, awiner wrote:
> need <os:Html code="${Data}"/> if the request includes any markup.

There was a long discussion which ended in having <os:Get>, and I only want to
reverse the decision and remove the tag if we have agreement from all folks who
wanted the the functionality (MySpace/Yahoo folks - please review this)

<os:Get> supports repeated and conditional download of data, so we lose some
functionality in the other constructs.

Think it's OK for the client side implementation and/or Shindig server-side
implementation to be naive and slow (deferred load via JS) - if developers like
the feature we can then improve performance.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b