Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4152)

Issue 3202042: pydoc.Helper.help() ignores input/output init parameters (issue 940286)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by bkad
Modified:
13 years, 1 month ago
Reviewers:
merwok, sasha
Base URL:
http://svn.python.org/projects/python/branches/py3k/
Visibility:
Public.

Patch Set 1 #

Total comments: 12

Patch Set 2 : changes based on merwok's comments #

Total comments: 2

Patch Set 3 : cleaning up the unit test #

Total comments: 6

Patch Set 4 : code style fixes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -7 lines) Patch
M Lib/pydoc.py View 1 2 3 5 chunks +19 lines, -6 lines 0 comments Download
M Lib/test/test_pydoc.py View 1 2 3 2 chunks +37 lines, -1 line 1 comment Download

Messages

Total messages: 9
merwok
The diff is short and simple, but introduces new arguments in some methods, which makes ...
13 years, 4 months ago (2010-11-21 22:46:15 UTC) #1
bkad
A couple of thoughts on the new arguments I've added: 1.) An alternative approach to ...
13 years, 4 months ago (2010-11-22 03:17:54 UTC) #2
merwok
> A couple of thoughts on the new arguments I've added: [...] Okay, I’m convinced. ...
13 years, 4 months ago (2010-11-22 13:51:36 UTC) #3
bkad
> Ah, I hadn’t seen that you were binding the name later in the file. ...
13 years, 4 months ago (2010-11-23 02:59:34 UTC) #4
merwok
>> Ah, I hadn’t seen that you were binding the name later in the file. ...
13 years, 4 months ago (2010-11-28 02:01:06 UTC) #5
sasha
Nothing of substance, just a few whitespace issues. http://codereview.appspot.com/3202042/diff/11001/Lib/pydoc.py File Lib/pydoc.py (right): http://codereview.appspot.com/3202042/diff/11001/Lib/pydoc.py#newcode1315 Lib/pydoc.py:1315: def ...
13 years, 4 months ago (2010-11-28 02:26:05 UTC) #6
sasha
http://codereview.appspot.com/3202042/diff/11001/Lib/pydoc.py File Lib/pydoc.py (right): http://codereview.appspot.com/3202042/diff/11001/Lib/pydoc.py#newcode1512 Lib/pydoc.py:1512: if output: better "if output is not None" or ...
13 years, 4 months ago (2010-11-28 02:29:54 UTC) #7
bkad
> >> Ah, I hadn’t seen that you were binding the name later in the ...
13 years, 4 months ago (2010-11-28 07:55:36 UTC) #8
merwok
13 years, 1 month ago (2011-02-04 00:23:55 UTC) #9
A last style remark.  The rest is good to go.

http://codereview.appspot.com/3202042/diff/19001/Lib/test/test_pydoc.py
File Lib/test/test_pydoc.py (right):

http://codereview.appspot.com/3202042/diff/19001/Lib/test/test_pydoc.py#newco...
Lib/test/test_pydoc.py:364: finally:
I prefer using self.addCleanup(setattr, pydoc, 'getpager', pydoc.getpager) at
the start of the method.  It’s cleaner to read than a try/finally and removes
the need to keep around references to monkey-patched objects.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b