Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3192)

Issue 319610043: Implement spacing-pair for MeasureCounter

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by david.nalesnik
Modified:
7 years ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Implement spacing-pair for MeasureCounter Since MeasureCounter grobs are bounded by columns, sophisticated horizontal positioning is available relative to "prefatory materials" (such as barlines, clefs, and key signatures) at the beginning and end of measures. This allows numbers to be placed above full-measure rests which have been similarly adjusted with 'spacing-pair. The previous default is established in the grob description: count objects are centered between BreakAlignment grobs. Paper_column::break_align_width is made available to Scheme as ly:paper-column:break-align-width.

Patch Set 1 #

Patch Set 2 : Add regtest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -26 lines) Patch
A input/regression/measure-counter-spacing-pair.ly View 1 1 chunk +57 lines, -0 lines 0 comments Download
M lily/paper-column.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M scm/define-grob-interfaces.scm View 1 chunk +2 lines, -1 line 0 comments Download
M scm/define-grobs.scm View 1 chunk +1 line, -0 lines 0 comments Download
M scm/output-lib.scm View 1 chunk +20 lines, -25 lines 0 comments Download

Messages

Total messages: 2
david.nalesnik
Please review -- thanks!
7 years ago (2017-03-31 00:57:27 UTC) #1
david.nalesnik
7 years ago (2017-03-31 01:00:18 UTC) #2
Add regtest
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b