Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(383)

Issue 318200043: Rework the Preinit framework into something simpler (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by dak
Modified:
5 years, 8 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Rework the Preinit framework into something simpler The previous introduction of the Preinit class had to work with uninitialized data members in a state before construction. Particularly for data structures like vector classes, this was quite awkward. Moving such structures into a separate class initialized before the smobifying base class fixes this deficiency and makes the behavior much more reliable, at the cost of making the class hierarchy a bit more nested.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -85 lines) Patch
M lily/engraver-group.cc View 1 chunk +1 line, -2 lines 0 comments Download
M lily/global-context.cc View 1 chunk +1 line, -2 lines 0 comments Download
M lily/include/engraver-group.hh View 1 chunk +7 lines, -3 lines 0 comments Download
M lily/include/global-context.hh View 1 chunk +7 lines, -3 lines 0 comments Download
M lily/include/modified-font-metric.hh View 2 chunks +7 lines, -3 lines 0 comments Download
M lily/include/music.hh View 2 chunks +7 lines, -4 lines 0 comments Download
M lily/include/open-type-font.hh View 1 chunk +9 lines, -7 lines 0 comments Download
M lily/include/pango-font.hh View 1 chunk +6 lines, -3 lines 0 comments Download
M lily/include/scheme-engraver.hh View 2 chunks +14 lines, -12 lines 0 comments Download
M lily/include/smobs.hh View 2 chunks +24 lines, -26 lines 0 comments Download
M lily/include/spanner.hh View 3 chunks +8 lines, -4 lines 0 comments Download
M lily/modified-font-metric.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/music.cc View 1 chunk +1 line, -2 lines 0 comments Download
M lily/open-type-font.cc View 1 chunk +1 line, -2 lines 0 comments Download
M lily/pango-font.cc View 1 chunk +1 line, -2 lines 0 comments Download
M lily/scheme-engraver.cc View 1 chunk +1 line, -3 lines 0 comments Download
M lily/spanner.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 1
lemzwerg
7 years, 2 months ago (2017-01-01 09:35:38 UTC) #1
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b