Prevent granados.ly image rotation in web.pdf

Issue 5128: Prevent granados.ly image rotation in web.pdf

granados.ly used 'landscape symbol for page settings.
As a result, granados.pdf which was generated from granados.ly
contained `/Rotate 90` that is not supported by XeTeX's PDFs including.
So the image in web.pdf which was generated by XeTeX
was rotated 90 degree counter-clockwise.

This commit makes the page settings does not have 'landscape symbol.
We append `landscape` to the name of the paper size itself.
So granados.ly image rotation in web.pdf is prevented.

See Notation Reference "Setting the paper size".

[dak, 2017-04-29 10:09:06]

https://codereview.appspot.com/317560043/diff/1/Documentation/ly-examples/gra...
File Documentation/ly-examples/granados.ly (right):

https://codereview.appspot.com/317560043/diff/1/Documentation/ly-examples/gra...
Documentation/ly-examples/granados.ly:16: % as landscape letter size instead of
'landscape symbol.
From NR "Setting the paper size":

   If the symbol ‘'landscape’ is added to the paper size function, pages
will be rotated by 90 degrees, and wider line widths will be set
accordingly.

     #(set-default-paper-size "a6" 'landscape)

   Swapping the paper dimensions _without_ having the print rotated
(like when printing to postcard size, or creating graphics for inclusion
rather than a standalone document) can be achieved by appending
‘landscape’ to the name of the paper size itself:

     #(set-default-paper-size "a6landscape")

[trueroad, 2017-04-29 12:14:34]

Use "letterlandscape"

[trueroad, 2017-04-29 12:18:31]

Thank you for your reviewing.

Here's new commit message.

    Issue 5128: Prevent granados.ly image rotation in web.pdf

    granados.ly used 'landscape symbol for page settings.
    As a result, granados.pdf which was generated from granados.ly
    contained `/Rotate 90` that is not supported by XeTeX's PDFs including.
    So the image in web.pdf which was generated by XeTeX
    was rotated 90 degree counter-clockwise.

    This commit makes the page settings does not have 'landscape symbol.
    We append `landscape` to the name of the paper size itself.
    So granados.ly image rotation in web.pdf is prevented.

    See Notation Reference "Setting the paper size".

https://codereview.appspot.com/317560043/diff/1/Documentation/ly-examples/gra...
File Documentation/ly-examples/granados.ly (right):

https://codereview.appspot.com/317560043/diff/1/Documentation/ly-examples/gra...
Documentation/ly-examples/granados.ly:16: % as landscape letter size instead of
'landscape symbol.
On 2017/04/29 10:09:05, dak wrote:
> From NR "Setting the paper size":
> 
>    If the symbol ‘'landscape’ is added to the paper size function, pages
> will be rotated by 90 degrees, and wider line widths will be set
> accordingly.
> 
>      #(set-default-paper-size "a6" 'landscape)
> 
>    Swapping the paper dimensions _without_ having the print rotated
> (like when printing to postcard size, or creating graphics for inclusion
> rather than a standalone document) can be achieved by appending
> ‘landscape’ to the name of the paper size itself:
> 
>      #(set-default-paper-size "a6landscape")

I've changed to "letterlandscape".

[dak, 2017-04-29 12:32:54]

https://codereview.appspot.com/317560043/diff/20001/Documentation/ly-examples...
File Documentation/ly-examples/granados.ly (right):

https://codereview.appspot.com/317560043/diff/20001/Documentation/ly-examples...
Documentation/ly-examples/granados.ly:12: % If we use 'landscape symbol for page
settings,
My personal opinion is to just leave out the comment here.  While the
"letterlandscape" paper size only existed since version 2.16.1 (issue 2737), it
has been the proper and documented thing to use for this case for a long enough
time that mentioning it here, particularly in the context of XeTeX, seems like
overkill.  In my opinion XeTeX does the right and actually expected thing and it
is rather random that this worked differently in other circumstances.

If we go to the bother of writing comments, it should rather be for the purpose
of documenting non-obvious properties of the current code rather than of an
ancient LilyPond version.

Even if it is frustrating that one spends a day of work on a change that finally
boils down to about 5 characters.

[trueroad, 2017-04-29 12:46:22]

Remove comment

[trueroad, 2017-04-29 12:48:07]

Thank you for your opinion.
I've removed the comment.

https://codereview.appspot.com/317560043/diff/20001/Documentation/ly-examples...
File Documentation/ly-examples/granados.ly (right):

https://codereview.appspot.com/317560043/diff/20001/Documentation/ly-examples...
Documentation/ly-examples/granados.ly:12: % If we use 'landscape symbol for page
settings,
On 2017/04/29 12:32:54, dak wrote:
> My personal opinion is to just leave out the comment here.  While the
> "letterlandscape" paper size only existed since version 2.16.1 (issue 2737),
it
> has been the proper and documented thing to use for this case for a long
enough
> time that mentioning it here, particularly in the context of XeTeX, seems like
> overkill.  In my opinion XeTeX does the right and actually expected thing and
it
> is rather random that this worked differently in other circumstances.
> 
> If we go to the bother of writing comments, it should rather be for the
purpose
> of documenting non-obvious properties of the current code rather than of an
> ancient LilyPond version.
> 
> Even if it is frustrating that one spends a day of work on a change that
finally
> boils down to about 5 characters.

Done.

[dak, 2017-04-29 13:35:31]

LGTM

Now the following does not concern this issue directly but I see two more
occurences in input/regression/landscape.ly and input/regression/page-links.ly .

I feel ambiguous about either here.  I could imagine leaving landscape.ly in
"true" landscape while merely using landscape paper size in page-links.ly.

Looking at the regtest outputs shows that the PDF collection of regtests shows
the examples in proper landscape while the HTML overview doesn't and uses quite
different page dimensions as well.  No idea why these versions would be as
drastically different as that.

As I said: this does not concern this issue.  It just looks like we have a few
other issues related to it...

[trueroad, 2017-05-06 07:46:34]

I've pushed to staging.

commit 6b5c2fe707c1dfaacdf574027d281288eed8baa3
Issue 5128: Prevent granados.ly image rotation in web.pdf