Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 316950043: Fix MusicXML reg tests that have both Lyrics and Chords (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by pkx166h
Modified:
7 years ago
Reviewers:
CC:
lilypond-devel_gnu.org, Yoda-JM
Visibility:
Public.

Description

Fix MusicXML reg tests that have both Lyrics and Chords As commented in the patch I did not find any documentation if a chord element can contain multiple lyrics, so I just assumed that the first note of the chord contained the Lyrics (consistant with Finale and Muscore exports).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M scripts/musicxml2ly.py View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3
pkx166h
Passes make, make check and a full make doc.
7 years, 3 months ago (2016-12-03 11:27:19 UTC) #1
pkx166h
Patch on countdown for Sun 7th Dec.
7 years, 3 months ago (2016-12-04 18:15:23 UTC) #2
pkx166h
7 years, 3 months ago (2016-12-07 13:13:09 UTC) #3
author	Vincent Le Ligeour <vincent.leligeour@gmail.com>	
	Wed, 7 Dec 2016 13:10:32 +0000 (13:10 +0000)
committer	James Lowe <pkx166h@gmail.com>	
	Wed, 7 Dec 2016 13:10:38 +0000 (13:10 +0000)
commit	503a553ab5a1ace4a4f03a321d2d353f253bf5f4

Thank you Vincent.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b