Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(1805)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
3164041
: Add comments to bus/connection.[ch]. (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by
Yusuke Sato
Modified:
14 years ago
Reviewers:
shawn.p.huang,
Peng Huang
,
Peng
CC:
satorux
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.
Description
Add comments to bus/connection.[ch]. BUG=none TEST=none
Patch Set 1
#
Created:
14 years ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+62 lines, -35 lines
)
Patch
M
bus/connection.h
View
1 chunk
+48 lines, -0 lines
0 comments
Download
M
bus/connection.c
View
12 chunks
+14 lines, -35 lines
0 comments
Download
Messages
Total messages: 2
Expand All Messages
|
Collapse All Messages
Yusuke Sato
14 years ago (2010-11-17 09:36:33 UTC)
#1
Sign in
to reply to this message.
Peng
On 2010/11/17 09:36:33, Yusuke Sato wrote: LGTM. Thanks.
14 years ago (2010-11-17 09:52:30 UTC)
#2
On 2010/11/17 09:36:33, Yusuke Sato wrote: LGTM. Thanks.
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 3164041: Add comments to bus/connection.[ch]. (Closed)
Created 14 years ago by Yusuke Sato
Modified 14 years ago
Reviewers: Peng Huang, shawn.p.huang_gmail.com, Peng
Base URL: git@github.com:ibus/ibus.git@master
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b