Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(560)

Issue 316340043: Add capability to build Japanese PDF documents

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by trueroad
Modified:
7 years ago
Reviewers:
davide.liessi, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 5082/3: Add comment to build Japanese PDF documents Building Japanese PDF documents requires Japanese fonts and some packages. Unfortunately, most developers do not have them. Therefore, Japanese PDF is not built by default. This commit adds a comment which describes the requirements to build Japanese PDF documents for the developer who wants to build them. Issue 5082/2: Use Japanese texinfo.tex loader for Japanese texi files To use texinfo.tex for Japanese, we need to use the Japanese loader texinfo-ja.tex instead of texinfo.tex. This commit replaces texinfo.tex used in Japanese texi files with texinfo-ja.tex. Issue 5082/1: Add Japanese texinfo.tex support files Japanese PDF documents are not built since texinfo.tex (until Texinfo 6.3) and TeX engine (pdfTeX) do not support Japanese. The new texinfo.tex (Texinfo 6.3+) and the modern TeX engine (XeTeX and LuaTeX) can handle Japanese PDF. This commit adds Japanese texinfo.tex support files from Texinfo SVN repository r7681. They consist of the following two files. texinfo-ja.tex Japanese texinfo.tex loader txi-ja.tex Japanese translations and font definitions for texinfo.tex

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+603 lines, -4 lines) Patch
M Documentation/ja/GNUmakefile View 1 1 chunk +27 lines, -0 lines 0 comments Download
M Documentation/ja/learning.tely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/ja/notation.tely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/ja/usage.tely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/ja/web.texi View 1 chunk +1 line, -1 line 0 comments Download
A tex/texinfo-ja.tex View 1 chunk +84 lines, -0 lines 0 comments Download
A tex/txi-ja.tex View 1 chunk +488 lines, -0 lines 0 comments Download

Messages

Total messages: 6
lemzwerg
LGTm https://codereview.appspot.com/316340043/diff/1/Documentation/ja/GNUmakefile File Documentation/ja/GNUmakefile (right): https://codereview.appspot.com/316340043/diff/1/Documentation/ja/GNUmakefile#newcode7 Documentation/ja/GNUmakefile:7: # By default, Japanese PDF documents are not ...
7 years ago (2017-03-06 12:32:15 UTC) #1
davide.liessi
2017-03-06 13:32 GMT+01:00 <lemzwerg@googlemail.com>: > https://codereview.appspot.com/316340043/diff/1/Documentation/ja/GNUmakefile#newcode24 > Documentation/ja/GNUmakefile:24: # (This package is for Chinese, but ...
7 years ago (2017-03-06 12:40:30 UTC) #2
trueroad
Fix comment
7 years ago (2017-03-06 13:29:49 UTC) #3
trueroad
Thank you for your reviewing. https://codereview.appspot.com/316340043/diff/1/Documentation/ja/GNUmakefile File Documentation/ja/GNUmakefile (right): https://codereview.appspot.com/316340043/diff/1/Documentation/ja/GNUmakefile#newcode7 Documentation/ja/GNUmakefile:7: # By default, Japanese ...
7 years ago (2017-03-06 13:32:07 UTC) #4
trueroad
Thank you for your reviewing. On 2017/03/06 12:40:30, davide.liessi wrote: > 2017-03-06 13:32 GMT+01:00 <mailto:lemzwerg@googlemail.com>: ...
7 years ago (2017-03-06 13:32:49 UTC) #5
trueroad
7 years ago (2017-03-14 12:37:51 UTC) #6
I've pushed to staging.

commit a013f6616bc50b9e89639d811dc77f62b5afb58d
Issue 5082/3: Add comment to build Japanese PDF documents

commit e4dad39f825a121253e8ddf35a971a111c7dacfc
Issue 5082/2: Use Japanese texinfo.tex loader for Japanese texi files

commit 00ac2227716450bd8fd58098e2f00a5d4aa73c02
Issue 5082/1: Add Japanese texinfo.tex support files
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b