Issue 3163041: Add comments to bus/factoryproxy.[ch].

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3163041: Add comments to bus/factoryproxy.[ch]. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Yusuke Sato

Modified:
13 years, 7 months ago

Reviewers:
shawn.p.huang, Peng Huang, Peng

CC:
satorux

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Add comments to bus/factoryproxy.[ch]. BUG=none TEST=none

Patch Set 2 : review fix #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -8 lines)			Patch
	M	bus/factoryproxy.h	View	1	2 chunks	+21 lines, -4 lines	0 comments	Download
	M	bus/factoryproxy.c	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Yusuke Sato

http://codereview.appspot.com/3163041/diff/1/bus/factoryproxy.h File bus/factoryproxy.h (right): http://codereview.appspot.com/3163041/diff/1/bus/factoryproxy.h#newcode80 bus/factoryproxy.h:80: * Get the result of bus_factory_proxy_create_engine call. This call ...

13 years, 7 months ago (2010-11-17 09:00:33 UTC) #1

Peng

13 years, 7 months ago (2010-11-17 09:31:37 UTC) #2

Yusuke Sato

Oh I see, thanks. Rewrote the comment. PTAL. On 2010/11/17 09:31:37, Shawn.P.Huang wrote: > http://codereview.appspot.com/3163041/diff/1/bus/factoryproxy.h ...

13 years, 7 months ago (2010-11-17 09:38:11 UTC) #3

Peng

13 years, 7 months ago (2010-11-17 09:45:47 UTC) #4

On 2010/11/17 09:38:11, Yusuke Sato wrote:
> Oh I see, thanks. Rewrote the comment.
> PTAL.
> 
> On 2010/11/17 09:31:37, Shawn.P.Huang wrote:
> > http://codereview.appspot.com/3163041/diff/1/bus/factoryproxy.h
> > File bus/factoryproxy.h (right):
> > 
> > http://codereview.appspot.com/3163041/diff/1/bus/factoryproxy.h#newcode80
> > bus/factoryproxy.h:80: * Get the result of bus_factory_proxy_create_engine
> call.
> > This call might block up to timeout milliseconds.
> > On 2010/11/17 09:00:34, Yusuke Sato wrote:
> > > > This call might block up to timeout milliseconds.
> > > 
> > > could you check if my understanding is correct?
> > No. Caller have to call it in the ready callback function. I will not block
> the
> > caller.
LGTM. THANKS

Expand All Messages | Collapse All Messages