Issue 3162041: Add comments to bus/registry.[ch].

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3162041: Add comments to bus/registry.[ch]. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by Yusuke Sato

Modified:
14 years ago

Reviewers:
shawn.p.huang, Peng Huang

CC:
satorux

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Add comments to bus/registry.[ch]. BUG=none TEST=none

Patch Set 3 : review fixes #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -42 lines)			Patch
	M	bus/registry.h	View		1 chunk	+46 lines, -1 line	0 comments	Download
	M	bus/registry.c	View	1 2	19 chunks	+59 lines, -41 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

http://codereview.appspot.com/3162041/diff/2001/bus/registry.c File bus/registry.c (right): http://codereview.appspot.com/3162041/diff/2001/bus/registry.c#newcode151 bus/registry.c:151: g_object_set_data ((GObject *) desc, "component", comp); I think those ...

14 years ago (2010-11-17 08:24:43 UTC) #2

Yusuke Sato

Fixed all. Thanks. http://codereview.appspot.com/3162041/diff/2001/bus/registry.c File bus/registry.c (right): http://codereview.appspot.com/3162041/diff/2001/bus/registry.c#newcode151 bus/registry.c:151: g_object_set_data ((GObject *) desc, "component", comp); ...

14 years ago (2010-11-17 08:30:38 UTC) #3

LGTM Thanks.

Expand All Messages | Collapse All Messages