Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2510)

Issue 316190043: Issue 1375: Scheme engravers support in engraver-init.ly and documentation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by dak
Modified:
5 years, 8 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 1375: Scheme engravers support in engraver-init.ly and documentation This is sort of basic. For one thing, registered engravers will bleed into the following sessions for now. For another, ly:register-translator is very rigid about the format of the translator description. Then there still is only support for Scheme engravers (rather than other translators). Documentation for the feature itself is basically non-existent, so are regtests. As long as the feature is in a state where more than internal use is not advisable, that's tolerable. Consists of commits: Register scheme engravers This registers Measure_counter_engraver and Span_stem_engraver to make them documented and callable like C++ engravers. Create Translator_creator class Previously, translators were created by copying from a context-less instantiation of the translator containing its documentation. This had several unpleasant consequences, the most problematic likely being the inability to register Scheme engravers because their documentation would be identical to all other Scheme engravers. A new Translator_creator class takes over the task of creating Translator instances when called with a context argument. As a result of joining the mechanisms for Scheme engravers and C++ engravers, ly:translator-name and ly:translator-description are reimplemented in a manner resembling object properties. Let Translator constructor take a Context argument This is the first step towards constructing rather than cloning translators when creating contexts. On its own, it does not make sense, but the change is large and mostly mechanical, so keeping it separate from the actually difficult parts makes sense.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+470 lines, -270 lines) Patch
M lily/accidental-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/ambitus-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/arpeggio-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/auto-beam-engraver.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M lily/axis-group-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/balloon-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/bar-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/bar-number-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/beam-collision-engraver.cc View 1 chunk +3 lines, -1 line 0 comments Download
M lily/beam-engraver.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M lily/beam-performer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/bend-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/break-align-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/breathing-sign-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/chord-name-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/chord-tremolo-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/clef-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/cluster-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/collision-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/completion-note-heads-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/completion-rest-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/concurrent-hairpin-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/context-def.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/control-track-performer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/cue-clef-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/custos-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/default-bar-line-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/dot-column-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/dots-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/double-percent-repeat-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/drum-note-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/drum-note-performer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/dynamic-align-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/dynamic-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/dynamic-performer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M lily/engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/episema-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/extender-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/figured-bass-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/figured-bass-position-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/fingering-column-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/fingering-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/font-size-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/footnote-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/forbid-break-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/fretboard-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/glissando-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/grace-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/grace-spacing-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/gregorian-ligature-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/grid-line-span-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/grid-point-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/grob-pq-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/horizontal-bracket-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/hyphen-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/include/coherent-ligature-engraver.hh View 1 chunk +3 lines, -0 lines 0 comments Download
M lily/include/engraver.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/gregorian-ligature-engraver.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/ligature-engraver.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/lily-proto.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/performer.hh View 1 chunk +3 lines, -0 lines 0 comments Download
M lily/include/scheme-engraver.hh View 2 chunks +1 line, -4 lines 0 comments Download
M lily/include/translator.hh View 6 chunks +59 lines, -21 lines 0 comments Download
M lily/include/translator.icc View 4 chunks +18 lines, -18 lines 0 comments Download
M lily/instrument-name-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/instrument-switch-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/keep-alive-together-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/key-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/key-performer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/kievan-ligature-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/laissez-vibrer-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/ledger-line-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/ligature-bracket-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/ligature-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/lyric-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/lyric-performer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/mark-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/measure-grouping-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/melody-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/mensural-ligature-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/metronome-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/midi-cc-performer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/multi-measure-rest-engraver.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M lily/new-fingering-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/note-head-line-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/note-heads-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/note-name-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/note-performer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/note-spacing-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/ottava-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/output-property-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/page-turn-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/paper-column-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/parenthesis-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/part-combine-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/percent-repeat-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/phrasing-slur-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/piano-pedal-align-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/piano-pedal-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/piano-pedal-performer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/pitch-squash-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/pitched-trill-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/pure-from-neighbor-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/repeat-acknowledge-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/repeat-tie-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/rest-collision-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/rest-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/rhythmic-column-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/scheme-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/script-column-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/script-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/script-row-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/separating-line-group-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/slash-repeat-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/slur-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/slur-performer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/spacing-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/span-arpeggio-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/span-bar-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/span-bar-stub-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/spanner-break-forbid-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/staff-collecting-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/staff-performer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M lily/staff-symbol-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/stanza-number-align-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/stanza-number-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/stem-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/system-start-delimiter-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/tab-note-heads-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/tab-staff-symbol-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/tab-tie-follow-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/tempo-performer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/text-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/text-spanner-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/tie-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/tie-performer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/time-signature-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/time-signature-performer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/timing-translator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/translator.cc View 3 chunks +4 lines, -16 lines 0 comments Download
M lily/translator-ctors.cc View 3 chunks +56 lines, -11 lines 0 comments Download
M lily/translator-group.cc View 1 chunk +20 lines, -36 lines 0 comments Download
M lily/translator-scheme.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M lily/trill-spanner-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/tuplet-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/tweak-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/vaticana-ligature-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/vertical-align-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/volta-engraver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M scm/scheme-engravers.scm View 1 chunk +23 lines, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b