Issue 3156041: Add comments about thread safety.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3156041: Add comments about thread safety. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Yusuke Sato

Modified:
13 years, 7 months ago

Reviewers:
shawn.p.huang, Peng Huang

CC:
satorux

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Add comments about thread safety. BUG=none TEST=none

Patch Set 2 : review fix #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	bus/dbusimpl.c	View	1	5 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Yusuke Sato

http://codereview.appspot.com/3156041/diff/1/bus/dbusimpl.c File bus/dbusimpl.c (right): http://codereview.appspot.com/3156041/diff/1/bus/dbusimpl.c#newcode1080 bus/dbusimpl.c:1080: if (G_UNLIKELY (IBUS_OBJECT_DESTROYED (dbus))) question: is this check thread-safe? ...

13 years, 7 months ago (2010-11-17 04:41:16 UTC) #1

Yusuke Sato

Talked with Peng offline, and added FIXME to the function. Peng, pls check the patch ...

13 years, 7 months ago (2010-11-17 07:03:57 UTC) #2

LGTM. Thanks

Expand All Messages | Collapse All Messages