Issue 3152042: Fix some crashs when engine processes are killed.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3152042: Fix some crashs when engine processes are killed. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Peng Huang

Modified:
13 years, 7 months ago

Reviewers:
Yusuke Sato, satorux

Base URL:
git@github.com:/ibus/ibus.git@master

Visibility:
Public.

Description

Fix some crashs when engine processes are killed. BUG=none TEST=manual

Patch Set 1 #

Patch Set 2 : Fix a compile warning #

Total comments: 2

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -26 lines)			Patch
M	bus/component.c	View	1 chunk	+0 lines, -1 line	2 comments	Download
M	bus/engineproxy.c	View	7 chunks	+39 lines, -12 lines	0 comments	Download
M	bus/ibusimpl.c	View	6 chunks	+7 lines, -8 lines	0 comments	Download
M	bus/registry.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	client/gtk2/ibusimcontext.c	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/ibusobject.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ibusproxy.c	View	3 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Yusuke Sato

LGTM. For the record, could you file a bug on crosbug.com as well if the ...

13 years, 7 months ago (2010-11-24 02:14:14 UTC) #1

Peng Huang

On 2010/11/24 02:14:14, Yusuke Sato wrote: > LGTM. > > For the record, could you ...

13 years, 7 months ago (2010-11-24 02:28:36 UTC) #2

Peng Huang

13 years, 7 months ago (2010-11-24 02:28:47 UTC) #3

http://codereview.appspot.com/3152042/diff/2001/bus/component.c
File bus/component.c (left):

http://codereview.appspot.com/3152042/diff/2001/bus/component.c#oldcode329
bus/component.c:329: 
On 2010/11/24 02:14:14, Yusuke Sato wrote:
> is this change necessary? :)

no. :)

Expand All Messages | Collapse All Messages