Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1845)

Issue 314130043: Add using Extract PDFmark for document building

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by trueroad
Modified:
7 years, 4 months ago
Reviewers:
pkx166h, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add using Extract PDFmark for document building Issue 5000/5: Add using Extract PDFmark for DocBook This commit adds using Extract PDFmark for Doc Book documents. Issue 5000/4: Add using Extract PDFmark for LaTeX This commit adds using Extract PDFmark for LaTeX documents. Issue 5000/3: Add using Extract PDFmark for Texinfo This commit adds using Extract PDFmark for Texinfo PDF documents. Issue 5000/2: Add font-export and never-embed options for document building This commit adds `-dfont-export-dir=[dir]` option and `-dgs-never-embed-fonts` option for document building. Issue 5000/1: Add checking Ghostscript 9.20+ and Extract PDFmark This commit adds checking Ghostscript 9.20+ and Extract PDFmark. They can reduce the disk space required for document building. They also can reduce the size of generated PDF document files. Even if they are missing, you can build documents. Ghostscript 9.20+: It is necessary for string named destinations. Ghostscript 9.19 and prior cannot handle them. http://bugs.ghostscript.com/show_bug.cgi?id=696974 Extract PDFmark: It is necessary for preserving named destinations and page mode. https://github.com/trueroad/extractpdfmark http://www.ctan.org/pkg/extractpdfmark

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix message 80 columns #

Total comments: 2

Patch Set 3 : Use `Ghostscript` and `Extract PDFmark` instead of `gs` and `extractpdfmark` #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
M config.make.in View 2 chunks +4 lines, -0 lines 0 comments Download
M configure.ac View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M make/lilypond-book-rules.make View 2 chunks +12 lines, -0 lines 0 comments Download
M make/lilypond-vars.make View 1 chunk +6 lines, -0 lines 0 comments Download
M make/lysdoc-targets.make View 1 chunk +4 lines, -0 lines 0 comments Download
M stepmake/stepmake/texinfo-rules.make View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9
lemzwerg
Very nice, LGTM! https://codereview.appspot.com/314130043/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/314130043/diff/1/configure.ac#newcode300 configure.ac:300: STEPMAKE_ADD_ENTRY(OPTIONAL,"(gs >= 9.20 and extractpdfmark can ...
7 years, 4 months ago (2016-11-18 18:04:55 UTC) #1
trueroad
Thank you for your reviewing. https://codereview.appspot.com/314130043/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/314130043/diff/1/configure.ac#newcode300 configure.ac:300: STEPMAKE_ADD_ENTRY(OPTIONAL,"(gs >= 9.20 and ...
7 years, 4 months ago (2016-11-19 02:51:30 UTC) #2
lemzwerg
Ah, bad wording, sorry. I don't care about the actual length of the message but ...
7 years, 4 months ago (2016-11-19 06:11:09 UTC) #3
trueroad
Fix message 80 columns
7 years, 4 months ago (2016-11-19 12:55:01 UTC) #4
trueroad
On 2016/11/19 06:11:09, lemzwerg wrote: > Ah, bad wording, sorry. I don't care about the ...
7 years, 4 months ago (2016-11-19 13:01:43 UTC) #5
pkx166h
Domou Hosoda-Sama. https://codereview.appspot.com/314130043/diff/20001/configure.ac File configure.ac (right): https://codereview.appspot.com/314130043/diff/20001/configure.ac#newcode305 configure.ac:305: [" documentation and the final PDF files.)"]) ...
7 years, 4 months ago (2016-11-19 14:06:07 UTC) #6
trueroad
Use `Ghostscript` and `Extract PDFmark` instead of `gs` and `extractpdfmark`
7 years, 4 months ago (2016-11-19 18:20:26 UTC) #7
trueroad
Thank you for your advice. https://codereview.appspot.com/314130043/diff/20001/configure.ac File configure.ac (right): https://codereview.appspot.com/314130043/diff/20001/configure.ac#newcode305 configure.ac:305: [" documentation and the ...
7 years, 4 months ago (2016-11-19 18:29:01 UTC) #8
trueroad
7 years, 4 months ago (2016-11-24 11:50:34 UTC) #9
I've pushed to staging.

commit 05d42dcaf03067eca83309339758fee441f38edf
Issue 5000/5: Add using Extract PDFmark for DocBook

commit cecca9a5dbc694bee54e9f7248b22e4d4a91c8da
Issue 5000/4: Add using Extract PDFmark for LaTeX

commit 5942efb8305c948eb05bb4ed7851e101ad16b70c
Issue 5000/3: Add using Extract PDFmark for Texinfo

commit f4ec9bac245b8d8382a396591b2a5df3b591828e
Issue 5000/2: Add font-export and never-embed options for document building

commit fe4e0f1ceb493437ff510565aa7c501ea959d0a7
Issue 5000/1: Add checking Ghostscript 9.20+ and Extract PDFmark
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b