Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1957)

Issue 313380043: Doc: Issue 5034: Expand documentation of mode-changing commands (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by Trevor Daniels
Modified:
7 years, 2 months ago
Reviewers:
thomasmorley651, t.daniels
Visibility:
Public.

Description

Doc: Issue 5034: Expand documentation of mode-changing commands Add general description of long and short forms and clarify wording generally. Add description of \lyrics Fix typos in chords and percussion

Patch Set 1 #

Total comments: 4

Patch Set 2 : Respond to Harm's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -35 lines) Patch
M Documentation/notation/changing-defaults.itely View 1 2 chunks +49 lines, -29 lines 0 comments Download
M Documentation/notation/chords.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/notation/percussion.itely View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6
thomasmorley651
Two nits. Otherwise LGTM https://codereview.appspot.com/313380043/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/313380043/diff/1/Documentation/notation/changing-defaults.itely#newcode2632 Documentation/notation/changing-defaults.itely:2632: into a @code{ChordNames} context. Or ...
7 years, 2 months ago (2017-01-22 18:43:42 UTC) #1
Trevor Daniels
Respond to Harm's comments
7 years, 2 months ago (2017-01-22 21:17:53 UTC) #2
Trevor Daniels
Thanks Harm! https://codereview.appspot.com/313380043/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/313380043/diff/1/Documentation/notation/changing-defaults.itely#newcode2632 Documentation/notation/changing-defaults.itely:2632: into a @code{ChordNames} context. On 2017/01/22 18:43:42, ...
7 years, 2 months ago (2017-01-22 21:18:32 UTC) #3
thomasmorley651
On 2017/01/22 21:18:32, Trevor Daniels wrote: > Thanks Harm! > > https://codereview.appspot.com/313380043/diff/1/Documentation/notation/changing-defaults.itely > File Documentation/notation/changing-defaults.itely ...
7 years, 2 months ago (2017-01-22 22:28:45 UTC) #4
t.daniels_treda.co.uk
thomasmorley65@gmail.com wrote Sunday, January 22, 2017 10:28 PM > LGTM Thanks! > Unrelated: > > ...
7 years, 2 months ago (2017-01-22 23:02:25 UTC) #5
Trevor Daniels
7 years, 2 months ago (2017-01-28 21:40:19 UTC) #6
Pushed to Staging as
553410afdd9496f7d9f1498e755ea18de8e70596

Closing ...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b