Add comments to bus/dbusimpl.[ch]

Add comments to bus/dbusimpl.[ch].

BUG=none
TEST=none

[Yusuke Sato, 2010-11-16 05:43:02]

http://codereview.appspot.com/3132041/diff/4001/bus/dbusimpl.c
File bus/dbusimpl.c (right):

http://codereview.appspot.com/3132041/diff/4001/bus/dbusimpl.c#newcode291
bus/dbusimpl.c:291: /* FIXME destruct _lock and _queue members. */
Please let me know if the FIXME is inappropriate.

http://codereview.appspot.com/3132041/diff/4001/bus/dbusimpl.c#newcode544
bus/dbusimpl.c:544: /* FIXME should we return G_DBUS_ERROR if rule is not found
in dbus->rules? */
Please let me know if the FIXME is inappropriate.

[Peng, 2010-11-16 06:27:04]

http://codereview.appspot.com/3132041/diff/4001/bus/dbusimpl.c
File bus/dbusimpl.c (right):

http://codereview.appspot.com/3132041/diff/4001/bus/dbusimpl.c#newcode291
bus/dbusimpl.c:291: /* FIXME destruct _lock and _queue members. */
On 2010/11/16 05:43:02, Yusuke Sato wrote:
> Please let me know if the FIXME is inappropriate.
Yeah. It is better to release them.

http://codereview.appspot.com/3132041/diff/4001/bus/dbusimpl.c#newcode456
bus/dbusimpl.c:456: const gchar uuid[] = "FIXME";
It is better to use pointer. Because the string "FIXME" could be shared with
other pointers.

http://codereview.appspot.com/3132041/diff/4001/bus/dbusimpl.c#newcode544
bus/dbusimpl.c:544: /* FIXME should we return G_DBUS_ERROR if rule is not found
in dbus->rules? */
On 2010/11/16 05:43:02, Yusuke Sato wrote:
> Please let me know if the FIXME is inappropriate.

Right. We could check the implementation of dbus-daemon. I guess it will return
some error.

http://codereview.appspot.com/3132041/diff/4001/bus/dbusimpl.c#newcode1046
bus/dbusimpl.c:1046: g_critical ("Can not forward the message - destination
unknown.");
I think maybe some clients will send messages to daemon with a wrong
destination, the daemon should handle it in appropriately. I don't think it is a
critical case.

[Yusuke Sato, 2010-11-16 06:34:47]

Fixed all. please take another look.

http://codereview.appspot.com/3132041/diff/4001/bus/dbusimpl.c
File bus/dbusimpl.c (right):

http://codereview.appspot.com/3132041/diff/4001/bus/dbusimpl.c#newcode456
bus/dbusimpl.c:456: const gchar uuid[] = "FIXME";
On 2010/11/16 06:27:04, Shawn.P.Huang wrote:
> It is better to use pointer. Because the string "FIXME" could be shared with
> other pointers.

Ok, reverted.

http://codereview.appspot.com/3132041/diff/4001/bus/dbusimpl.c#newcode1046
bus/dbusimpl.c:1046: g_critical ("Can not forward the message - destination
unknown.");
Ok, let me remove the logging for now.

On 2010/11/16 06:27:04, Shawn.P.Huang wrote:
> I think maybe some clients will send messages to daemon with a wrong
> destination, the daemon should handle it in appropriately. I don't think it is
a
> critical case.

[Peng, 2010-11-16 06:37:04]

On 2010/11/16 06:34:47, Yusuke Sato wrote:
> Fixed all. please take another look.
> 
> http://codereview.appspot.com/3132041/diff/4001/bus/dbusimpl.c
> File bus/dbusimpl.c (right):
> 
> http://codereview.appspot.com/3132041/diff/4001/bus/dbusimpl.c#newcode456
> bus/dbusimpl.c:456: const gchar uuid[] = "FIXME";
> On 2010/11/16 06:27:04, Shawn.P.Huang wrote:
> > It is better to use pointer. Because the string "FIXME" could be shared with
> > other pointers.
> 
> Ok, reverted.
> 
> http://codereview.appspot.com/3132041/diff/4001/bus/dbusimpl.c#newcode1046
> bus/dbusimpl.c:1046: g_critical ("Can not forward the message - destination
> unknown.");
> Ok, let me remove the logging for now.
> 
> On 2010/11/16 06:27:04, Shawn.P.Huang wrote:
> > I think maybe some clients will send messages to daemon with a wrong
> > destination, the daemon should handle it in appropriately. I don't think it
is
> a
> > critical case.

LGTM. Thanks.