Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(341)

Issue 312530043: LyricHyphen whiteout (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by pkx166h
Modified:
7 years ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

LyricHyphen whiteout Issue 5033 A proper outline whiteout would be ideal, but it is not currently implemented. The current code fails because you need a relatively large whiteout area for a small object. A brute force fix is to increase the number of iterations, but the result would be a pdf with a high percentage of whiteout code. There is the case where a long melisma produces a single hyphen event that generates a lot of hyphens that cross a number of mensuration lines. Rectangular or roundedbox whiteout will produce gaps in all mensuration lines crossed, even if there is no collision. That's not acceptable.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M lily/lyric-hyphen.cc View 3 chunks +14 lines, -2 lines 0 comments Download
M scm/define-grob-properties.scm View 1 chunk +7 lines, -3 lines 0 comments Download
M scm/stencil.scm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1
pkx166h
7 years ago (2017-03-12 18:28:29 UTC) #1
author	Knut Petersen <knut_petersen@t-online.de>	
	Sat, 4 Mar 2017 18:10:19 +0000 (18:10 +0000)
committer	James Lowe <pkx166h@gmail.com>	
	Fri, 10 Mar 2017 18:32:08 +0000 (18:32 +0000)
commit	2dc76513c4edb8e18e6170069677eb0dd9b54209
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b