Issue 3123041: Replaced TIntermLoop::testFirst with TIntermLoop::loopType to clearly indicat...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3123041: Replaced TIntermLoop::testFirst with TIntermLoop::loopType to clearly indicat... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by Alok Priyadarshi

Modified:
14 years, 9 months ago

Reviewers:
kbr1, dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Replaced TIntermLoop::testFirst with TIntermLoop::loopType to clearly indicate which type of loop it is. In some cases it is not possble to differentiate between a for-loop and while-loop. BUG=48

Patch Set 1 #

Total comments: 1

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -22 lines)			Patch
M	src/compiler/Intermediate.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/compiler/OutputGLSL.cpp	View	3 chunks	+11 lines, -2 lines	0 comments	Download
M	src/compiler/OutputHLSL.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/compiler/glslang.y	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/compiler/glslang_tab.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/compiler/intermOut.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/intermediate.h	View	1 chunk	+13 lines, -8 lines	1 comment	Download
M	src/compiler/localintermediate.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

kbr1

LGTM with one comment-related comment. http://codereview.appspot.com/3123041/diff/1/src/compiler/intermediate.h File src/compiler/intermediate.h (right): http://codereview.appspot.com/3123041/diff/1/src/compiler/intermediate.h#newcode293 src/compiler/intermediate.h:293: TIntermTyped *terminal; // expression ...

14 years, 9 months ago (2010-11-15 22:08:26 UTC) #2

LGTM (with Ken's comments addressed).

Daniel

Expand All Messages | Collapse All Messages