Issue 312300043: Replace midi.c with midi.py

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 312300043: Replace midi.c with midi.py

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 3 months ago by Graham Percival

Modified:
7 years, 3 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Remove midi.c midi2ly: replace unprintables with ~ midi2ly: fix non-printable in MIDI text Add rewrite of midi.c in python Work was done in 2012, and came from here: https://codereview.appspot.com/7016046/

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+211 lines, -474 lines)			Patch
M	python/GNUmakefile	View	2 chunks	+1 line, -3 lines	0 comments	Download
D	python/midi.c	View	1 chunk	+0 lines, -469 lines	0 comments	Download
A	python/midi.py	View	1 chunk	+199 lines, -0 lines	0 comments	Download
M	scripts/midi2ly.py	View	1 chunk	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Graham Percival

7 years, 3 months ago (2017-01-20 01:45:06 UTC) #1

Please review.  Running "make install" does *not* result in a usable midi2ly,
but that's an existing problem not related to this (which I'll discuss
separately).

For testing purposes, you can use:
    PYTHONPATH=$HOME/.local/share/lilypond/2.19.55/python/ midi2ly

(assuming that you installed to $HOME/.local/ )

Expand All Messages | Collapse All Messages