Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2448)

Issue 311060043: Fix issue where Musicxml2ly generates improper code for minor chords (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by pkx166h
Modified:
7 years, 6 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix issue where Musicxml2ly generates improper code for minor chords The solutions for the invalid combinations are provided in python/musicexp.py. A colon is added if a colon-less chord (i.e., major) has modifications. Adding additions checks for a trailing digit, if none, the leading period is omitted. Note that the changes in python/musicexp.py are harmless to an un-patched scripts/musicxml2ly. Doc: update toplevel-score-handler definition reference The file where the default handler is defined has changed. Merge branch 'master' into translation Doc: fix bad xref mentionned in snippets.bigtexi.log Web-ja: fix links Merge branch 'master' into translation Doc-fr: NR-input web-fr: updates for new front page Web-ja: update translation Issue 4969: Update texinfo.tex from upstream texinfo.tex ver. 2016-09-17.16 It is newer than Texinfo-6.3's. Issue 4972: Make music-filter more conservative Deleting music when its 'elements field becomes null? led to repeat chords disappearing when articulations were removed.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+664 lines, -494 lines) Patch
M Documentation/fr/macros.itexi View 3 chunks +6 lines, -3 lines 0 comments Download
M Documentation/fr/notation/input.itely View 3 chunks +5 lines, -2 lines 0 comments Download
M Documentation/fr/web.texi View 3 chunks +56 lines, -7 lines 0 comments Download
M Documentation/fr/web/community.itexi View 4 chunks +5 lines, -5 lines 0 comments Download
M Documentation/fr/web/introduction.itexi View 2 chunks +6 lines, -6 lines 0 comments Download
M Documentation/ja/web.texi View 3 chunks +58 lines, -6 lines 0 comments Download
M Documentation/ja/web/community.itexi View 4 chunks +5 lines, -5 lines 0 comments Download
M Documentation/ja/web/introduction.itexi View 3 chunks +5 lines, -5 lines 0 comments Download
M Documentation/notation/input.itely View 1 chunk +3 lines, -2 lines 0 comments Download
M Documentation/snippets/midi-intro.itely View 1 chunk +1 line, -2 lines 0 comments Download
M python/musicexp.py View 1 chunk +10 lines, -1 line 0 comments Download
M scm/music-functions.scm View 1 chunk +11 lines, -9 lines 0 comments Download
M scripts/musicxml2ly.py View 2 chunks +6 lines, -6 lines 0 comments Download
M tex/texinfo.tex View 69 chunks +487 lines, -435 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b