Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(119)

Issue 3110041: Malte's test issue 122 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by Malte
Modified:
15 years ago
Reviewers:
karpase
Visibility:
Public.

Patch Set 1 #

Total comments: 24
Unified diffs Side-by-side diffs Delta from patch set Stats (+489 lines, -148 lines) Patch
M src/search/general_eager_best_first_search.cc View 2 chunks +2 lines, -2 lines 2 comments Download
M src/search/landmarks/h_m_landmarks.h View 2 chunks +3 lines, -1 line 1 comment Download
M src/search/landmarks/h_m_landmarks.cc View 4 chunks +42 lines, -3 lines 5 comments Download
M src/search/landmarks/lama_ff_synergy.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/search/landmarks/lama_ff_synergy.cc View 3 chunks +39 lines, -28 lines 2 comments Download
M src/search/landmarks/landmark_cost_assignment.h View 1 chunk +3 lines, -1 line 1 comment Download
M src/search/landmarks/landmark_cost_assignment.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/search/landmarks/landmark_count_heuristic.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/search/landmarks/landmark_count_heuristic.cc View 4 chunks +42 lines, -88 lines 2 comments Download
M src/search/landmarks/landmarks_graph.h View 4 chunks +19 lines, -2 lines 0 comments Download
M src/search/landmarks/landmarks_graph.cc View 3 chunks +54 lines, -7 lines 3 comments Download
M src/search/landmarks/landmarks_graph_rpg_exhaust.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/search/landmarks/landmarks_graph_rpg_exhaust.cc View 2 chunks +35 lines, -0 lines 1 comment Download
M src/search/landmarks/landmarks_graph_rpg_sasp.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/search/landmarks/landmarks_graph_rpg_sasp.cc View 2 chunks +36 lines, -0 lines 0 comments Download
M src/search/landmarks/landmarks_graph_rpg_search.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/search/landmarks/landmarks_graph_rpg_search.cc View 2 chunks +59 lines, -4 lines 1 comment Download
M src/search/landmarks/landmarks_graph_zhu_givan.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/search/landmarks/landmarks_graph_zhu_givan.cc View 2 chunks +36 lines, -0 lines 1 comment Download
M src/search/option_parser.h View 4 chunks +14 lines, -0 lines 2 comments Download
M src/search/option_parser.cc View 4 chunks +56 lines, -0 lines 2 comments Download
M src/search/planner.cc View 1 chunk +3 lines, -0 lines 1 comment Download
M src/search/plugin.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/search/plugin.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4
karpase
http://codereview.appspot.com/3110041/diff/1/src/search/general_eager_best_first_search.cc File src/search/general_eager_best_first_search.cc (left): http://codereview.appspot.com/3110041/diff/1/src/search/general_eager_best_first_search.cc#oldcode275 src/search/general_eager_best_first_search.cc:275: This can't be right!!!!! :-) http://codereview.appspot.com/3110041/diff/1/src/search/general_eager_best_first_search.cc File src/search/general_eager_best_first_search.cc (right): ...
15 years, 1 month ago (2010-11-15 20:02:42 UTC) #1
Malte
Added a few comments mostly on formatting (not terribly important, but worth saying once). http://codereview.appspot.com/3110041/diff/1/src/search/landmarks/h_m_landmarks.cc ...
15 years, 1 month ago (2010-11-15 20:09:46 UTC) #2
Malte
Some more stuff. Still a bunch of files to go. http://codereview.appspot.com/3110041/diff/1/src/search/option_parser.cc File src/search/option_parser.cc (right): http://codereview.appspot.com/3110041/diff/1/src/search/option_parser.cc#newcode110 ...
15 years, 1 month ago (2010-11-15 20:31:29 UTC) #3
Malte
15 years, 1 month ago (2010-11-15 20:50:18 UTC) #4
Sent remaining comments (mostly very small stuff).

Let me know when you've got the new revision done and I'll upload an updated
patch. (Since I started this one on Rietveld, it's probably better if I also
update it. In general, it of course makes more sense for the developer to
initiate the review.)

http://codereview.appspot.com/3110041/diff/1/src/search/landmarks/h_m_landmar...
File src/search/landmarks/h_m_landmarks.cc (right):

http://codereview.appspot.com/3110041/diff/1/src/search/landmarks/h_m_landmar...
src/search/landmarks/h_m_landmarks.cc:4: static LandmarksGraphPlugin
landmarks_graph_new_plugin(
The object name should follow the class name: h_m_landmarks_plugin

http://codereview.appspot.com/3110041/diff/1/src/search/landmarks/landmark_co...
File src/search/landmarks/landmark_cost_assignment.h (right):

http://codereview.appspot.com/3110041/diff/1/src/search/landmarks/landmark_co...
src/search/landmarks/landmark_cost_assignment.h:21: private:
Drop private: at the top of the class definition; it's a no-op.

http://codereview.appspot.com/3110041/diff/1/src/search/landmarks/landmark_co...
File src/search/landmarks/landmark_count_heuristic.cc (right):

http://codereview.appspot.com/3110041/diff/1/src/search/landmarks/landmark_co...
src/search/landmarks/landmark_count_heuristic.cc:39: cerr << "Reasonable
orderings can not be used for admissble heuristics" << endl;
"can not" => "cannot"

Or maybe better "are not supported" because I actually think they *can* be used
if used properly. :->

http://codereview.appspot.com/3110041/diff/1/src/search/landmarks/landmark_co...
src/search/landmarks/landmark_count_heuristic.cc:336:
option_parser.add_bool_option("alm",
"alm" => "action_landmarks"

http://codereview.appspot.com/3110041/diff/1/src/search/landmarks/landmarks_g...
File src/search/landmarks/landmarks_graph.cc (right):

http://codereview.appspot.com/3110041/diff/1/src/search/landmarks/landmarks_g...
src/search/landmarks/landmarks_graph.cc:66: use_external_inconsistencies(false)
{
Is use_external_inconsistencies respected? The code below doesn't seem to check
it. Why is is set to false by default; isn't it actually used by default? It it
set anywhere?

http://codereview.appspot.com/3110041/diff/1/src/search/landmarks/landmarks_g...
src/search/landmarks/landmarks_graph.cc:1351:
lm_graph->read_external_inconsistencies();
Shouldn't this check if use_external_inconsistencies is true? But I guess it
can't if it's static. Hmm... maybe I'm confused.

http://codereview.appspot.com/3110041/diff/1/src/search/landmarks/landmarks_g...
src/search/landmarks/landmarks_graph.cc:1389:
option_parser.add_bool_option("use_action_landmarks",
This option should have the same name as in the other file (where it was called
"alm". This long name is a good one.)

http://codereview.appspot.com/3110041/diff/1/src/search/landmarks/landmarks_g...
File src/search/landmarks/landmarks_graph_rpg_exhaust.cc (right):

http://codereview.appspot.com/3110041/diff/1/src/search/landmarks/landmarks_g...
src/search/landmarks/landmarks_graph_rpg_exhaust.cc:9: static
LandmarksGraphPlugin landmarks_graph_new_plugin(
Shouldn't this be called "landmarks_graph_exhaust_plugin"? (Not that the name
matters...)

http://codereview.appspot.com/3110041/diff/1/src/search/landmarks/landmarks_g...
File src/search/landmarks/landmarks_graph_rpg_search.cc (right):

http://codereview.appspot.com/3110041/diff/1/src/search/landmarks/landmarks_g...
src/search/landmarks/landmarks_graph_rpg_search.cc:5: static
LandmarksGraphPlugin landmarks_graph_new_plugin(
Should be called landmark_graph_rpg_search_plugin.

http://codereview.appspot.com/3110041/diff/1/src/search/landmarks/landmarks_g...
File src/search/landmarks/landmarks_graph_zhu_givan.cc (right):

http://codereview.appspot.com/3110041/diff/1/src/search/landmarks/landmarks_g...
src/search/landmarks/landmarks_graph_zhu_givan.cc:16: static
LandmarksGraphPlugin landmarks_graph_new_plugin(
Should be galled landmark_graph_zhu_givan_plugin.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b