Issue 310070043: Doc: Issue 4958: CG: Expand description of the engraver hooks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 310070043: Doc: Issue 4958: CG: Expand description of the engraver hooks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 8 months ago by Trevor Daniels

Modified:
7 years, 8 months ago

Reviewers:

Visibility:
Public.

More Reviews

Description

Doc: Issue 4958: CG: Expand description of the engraver hooks The previous rather terse description did not make it clear that grobs may not be created in the stop-translation-timestep hook. Thanks to David K for the text.

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -5 lines)			Patch
	M	Documentation/contributor/programming-work.itexi	View		1 chunk	+23 lines, -5 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Trevor Daniels

7 years, 8 months ago (2016-09-02 22:20:19 UTC) #1

Message was sent while issue was closed.

Pushed to Staging as
7a6871397b80a624067ced8381fced65d4f6f246

Closing ...

Expand All Messages | Collapse All Messages